Replace collapsible group and panel directives with the existing directives from angular-bootstrap
Bug #1411636 reported by
Timur Sufiev
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Merlin |
Fix Committed
|
Wishlist
|
Unassigned | ||
Bug Description
Angular-bootstrap package provides a number of angular directives that we've reinvented in Merlin. It is quite possible that our implementations are inferior to the angular-bootstrap solutions, so it makes sense to study these solutions and if they fit in our use-cases use them instead. This also would lessen the amount of code in Merlin's directives.
Starting point for the study is http://
| Changed in merlin: | |
| importance: | Undecided → Wishlist |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to merlin (master) | #1 |
| Changed in merlin: | |
| status: | New → Fix Committed |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit e5b8fb8a3acc085
Author: Timur Sufiev <email address hidden>
Date: Mon Apr 27 17:59:38 2015 +0300
Rewrite <panel> and <collapsible-group> directives
Use 'collapse' directive from angular-bootstrap inside them instead of
hand-written bootstrap css transitions. Clicking on panel title no
longer collapses/expands panel contents - this is done in order enable
panel entity name in-line editing in next commit.
Change-Id: Ifcc32cd74a5482
Closes-Bug: #1411636
Closes-Bug: #1428719