Comments support

[Adrien Cunin]

Merge-o-Matic should support comments, like DaD does (that includes support for bug links to LP and Debian BTS).

I'm currently working on that, rewriting DaD's code in python.
Comments from DaD should be migrated to MoM. It's just a matter of copying http://dad.dunnewind.net/comments.

[Adrien Cunin (adri2000)]

Here it is :) (bzr branch).

[Adrien Cunin (adri2000)]

I've added automatic removal of obsolete comments (ie. the package has been merged) to my branch today.

[Scott James Remnant (Canonical) (canonical-scott)]

This still depends on server support that is going to be incredibly difficult to get.

From the core, it's entirely unclear to me why this cannot be done in CGI.

[Adrien Cunin (adri2000)]

What do you mean by "server support"?
IIRC, when I was working on this feature, you told me that Canonical sysadmins weren't really fond of php, but that mod_python should work.
For your CGI question, I don't know if it can be done nor how it would be done.

[Adrien Cunin (adri2000)]

Scott, what is blocking the resolution of this bug?

[Scott James Remnant (Canonical) (canonical-scott)]

Exactly what I said above.

The patch requires server support that we don't have.

[Adrien Cunin (adri2000)]

I'm afraid I don't get what "server support" is.

[Adrien Cunin (adri2000)]

More changes in my branch, some of which try to address the potential security issues. Please take a look. The code is still running on my webserver (the link is on the branch page), so you can try it and see if you spot anything to fix (security related or not).

[Scott James Remnant (Canonical) (canonical-scott)]

Would appreciate a Security Review of the branch if you have time.

[Kees Cook (kees)]

https://code.launchpad.net/~adri2000/merge-o-matic/dev/+merge/572

More work is needed to make it XSS safe.

[Adrien Cunin (adri2000)]

Thanks for taking the time to review it Kees. I replied on the merge proposal page.

[Adrien Cunin (adri2000)]

Fixed, finally!