basic pagination support

Bug #234667 reported by ashcrow on 2008-05-24
4
Affects Status Importance Assigned to Milestone
Meow
Medium
ashcrow

Bug Description

Basic pagination support was requested. Attached is a patch that implements pagination using $CONTEXT/page/$PAGE_NO/ mappings.

Related branches

ashcrow (stevem-gnulinux) wrote :
Eric Moritz (ericmoritz) wrote :

A couple things before merging,

The tail block is for things like javascript that should be loaded last on the page, can you move the tail block back to the bottom and add a pagination block for your needs?

In the current trunk, there is a script called pep8.sh that uses pep8.py, this checks your code to make sure it conforms to the pep8 style guide. Can you run that script and fix the problems it finds. This will keep the code in a consistent style.

It's silly things like no trailing spaces, 4 spaces per indention level, etc. Pretty simple. The pep8.sh script makes it pretty easy to acomplish.

If I apply this patch it'll undo all the changes I made last night to conform to pep8.

Thanks,
Eric.

ashcrow (stevem-gnulinux) wrote :

sure, will do

ashcrow (stevem-gnulinux) wrote :

Branch updated, patch attached.

[steve@tachikoman pagination]$ ./pep8.sh
[steve@tachikoman pagination]$

  • unnamed Edit (1.3 KiB, text/html; charset=ISO-8859-1)

Here, I put some final touches on your branch, let me know if it works for
you. It was cut from r48 for your branch.

On Sun, May 25, 2008 at 3:40 PM, ashcrow <email address hidden> wrote:

> Branch updated, patch attached.
>
> [steve@tachikoman pagination]$ ./pep8.sh
> [steve@tachikoman pagination]$
>
> ** Attachment added: "pagination plus pep8. changes"
> http://launchpadlibrarian.net/14703903/pagination_plus_pep8.patch
>
> --
> basic pagination support
> https://bugs.launchpad.net/bugs/234667
> You received this bug notification because you are a member of Meow
> Developers, which is the registrant for Meow.
>
> Status in Meow: New
>
> Bug description:
> Basic pagination support was requested. Attached is a patch that implements
> pagination using $CONTEXT/page/$PAGE_NO/ mappings.
>

Eric Moritz (ericmoritz) wrote :

Here is some finishing touches on your branch. pagination_results would throw an InvalidPage exception if the page number in the url was outside the range. I caught that and threw a Http404 instead.

There were a few little changes as well.

Thanks again for your work.

This is based on revision 48 of your branch.

ashcrow (stevem-gnulinux) wrote :

Merged and pushed into pagination branch.

Patch based off trunk attached.

Eric Moritz (ericmoritz) on 2008-05-28
Changed in meow:
assignee: nobody → stevem-gnulinux
importance: Undecided → Medium
status: New → Fix Committed
Changed in meow:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints

Bug attachments