Invalid categories added to first launcher in top-level directory under XFCE

Bug #1605973 reported by OmegaPhil
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

This general category problem was mentioned in another ticket somewhere but I couldn't find it whilst searching so creating this ticket.

While testing I had a suspicious failure where I deleted a the first launcher inside a custom top-level directory, and suddenly the directory entry turned into that deleted launcher, at the top level. Further breakage followed.

Testing creation of a new directory, I noticed that the first launcher created had invalid XFCE categories applied - 'X-XFCE' and 'X-Xfce-Toplevel' - this is a launcher inside a top-level directory, but not top-level itself. I suspect these categories will later confuse where the launcher ends up.

I traced the problem to, which assumes that if it can't find a parent, you must be adding the launcher to the top level (so ignores the fact that you might be adding a launcher to a top-level directory that has no items, and therefore the selection would still be at the top level).


Revision history for this message
OmegaPhil (omegaphil) wrote :
Revision history for this message
Sean Davis (bluesabre) wrote :
Changed in menulibre:
status: New → Fix Committed
OmegaPhil (omegaphil)
Changed in menulibre:
assignee: nobody → OmegaPhil (omegaphil)
Revision history for this message
OmegaPhil (omegaphil) wrote :

This has started to break again?? Addition of a launcher to a top-level directory resulted in the launcher taking on the top-level categories...

After talking with Sean, I have fixed this and added a dialog to ask the user whether they want to add into or at the same level as a selected directory, when they add a launcher.

Changed in menulibre:
status: Fix Committed → Confirmed
Sean Davis (bluesabre)
Changed in menulibre:
assignee: OmegaPhil (omegaphil) → nobody
importance: Undecided → Unknown
status: Confirmed → Unknown
Changed in menulibre:
status: Unknown → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.