Invalid categories added to first launcher in top-level directory under XFCE

[OmegaPhil]

This general category problem was mentioned in another ticket somewhere but I couldn't find it whilst searching so creating this ticket.

While testing I had a suspicious failure where I deleted a the first launcher inside a custom top-level directory, and suddenly the directory entry turned into that deleted launcher, at the top level. Further breakage followed.

Testing creation of a new directory, I noticed that the first launcher created had invalid XFCE categories applied - 'X-XFCE' and 'X-Xfce-Toplevel' - this is a launcher inside a top-level directory, but not top-level itself. I suspect these categories will later confuse where the launcher ends up.

I traced the problem to MenulibreApplication.py:MenulibreWindow.add_launcher, which assumes that if it can't find a parent, you must be adding the launcher to the top level (so ignores the fact that you might be adding a launcher to a top-level directory that has no items, and therefore the selection would still be at the top level).

Fixed!

[Sean Davis (bluesabre)]

Patch works great! Applied at: https://bazaar.launchpad.net/~menulibre-dev/menulibre/master/revision/344

[OmegaPhil (omegaphil)]

This has started to break again?? Addition of a launcher to a top-level directory resulted in the launcher taking on the top-level categories...

After talking with Sean, I have fixed this and added a dialog to ask the user whether they want to add into or at the same level as a selected directory, when they add a launcher.