MenuLibre

Icon used for a new directory should be gtk-directory

Bug #1605905 reported by OmegaPhil on 2016-07-23

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	MenuLibre	Fix Released	Undecided	OmegaPhil	MenuLibre 2.1.4

Bug Description

Looks like applications-other/gnome-other icon is being used when you create a directory, do you agree that gtk-directory should be used?

Revision history for this message

OmegaPhil (omegaphil) wrote on 2016-07-23:

Actually it seems gnome-fs-directory is used, going by the appearance.

Revision history for this message

Sean Davis (bluesabre) wrote on 2016-08-19:

Per https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-DIRECTORY:CAPS it looks like we should actually use the named icon "folder" instead of "gtk-directory".

In the past, I have elected to use "applications-other/gnome-other" since it represented a generic applications folder. At this point, it would probably be an improvement to just use an actual folder.

OmegaPhil (omegaphil) on 2016-08-19

Changed in menulibre:
assignee:	nobody → OmegaPhil (omegaphil)
status:	New → Confirmed

Revision history for this message

OmegaPhil (omegaphil) wrote on 2016-08-20:

change-new-directory-icon-to-stock-gtk3-folder-icon.patch Edit (589 bytes, text/plain)

Ah I see, so in your eyes the directory takes on an identity like the normal top-level ones do. For me I just create bogstandard directories whereever to store launchers, so I've always thought of them as generic directories.

Here is the patch to change the icon.

Revision history for this message

Sean Davis (bluesabre) wrote on 2016-08-27:

Thanks for the patch! Applied at https://bazaar.launchpad.net/~menulibre-dev/menulibre/master/revision/348