Crash of Menulibre and Alacarte due to conflict in xfce-applications.menu

[maxnax]

[SRU - Test Case]
1. Move a launcher into the Settings directory.
2. Move a different launcher from the Settings directory into another directory.

[SRU - Expected Results]
[[MenuLibre 2.0.3]]
There are mutliple entries in xfce-applications.menu with the label "Settings". Opening menulibre or alacarte after this will cause the applications to fail.

NOTE: Once these applications fail, the file ~/.config/xfce-applications.menu MUST be removed so the corrupt menu file can be replaced.

[[MenuLibre 2.0.4]]
Each directory name in xfce-applications.menu will appear only once. Opening menulibre or alacarte after this will work as expected.

[Original Report]
Ubuntu 14.04 with XFCE4.10

In /etc/xdg/menus/xfce-applications.menu xfce-settings.directory has name <Name>Settings</Name>

But in ~/.config/menus/xfce-applications.menu after some editing with menulibre it appears as <Name>Preferences</Name>

Then there appears double "<Menuname>Preferences</Menuname>" line in <Layout> section of ~/.config/menus/xfce-applications.menu , that causes permanent crash of both Alacarte and Menulibre , until you delete one of <Menuname>Preferences</Menuname> lines or ~/.config/menus/xfce-applications.menu entirely

There's way to rename xfce-settings.directory in /etc/xdg/menus/xfce-applications.menu to <Name>Preferences</Name> and then everything will be ok. But it's not proper way...
Alacarte do not causes such effects...

Content /etc/xdg/menus/xfce-applications.menu

<Menu>
    <Name>Xfce</Name>

    <DefaultAppDirs/>
    <DefaultDirectoryDirs/>
    <DefaultMergeDirs/>

    <Include>
        <Category>X-Xfce-Toplevel</Category>
    </Include>

    <Layout>
        <Filename>xfce4-run.desktop</Filename>
        <Separator/>
        <Filename>exo-terminal-emulator.desktop</Filename>
        <Filename>exo-file-manager.desktop</Filename>
        <Filename>exo-mail-reader.desktop</Filename>
        <Filename>exo-web-browser.desktop</Filename>
        <Merge type="all"/>
        <Separator/>
        <Filename>xfce4-about.desktop</Filename>
        <Filename>xfce4-session-logout.desktop</Filename>
    </Layout>

    <Menu>
        <Name>Settings</Name>
        <Directory>xfce-settings.directory</Directory>
        <Include>
            <Category>Settings</Category>
        </Include>

        <Layout>
            <Filename>xfce-settings-manager.desktop</Filename>
            <Separator/>
            <Merge type="all"/>
        </Layout>
    </Menu>

Content ~/.config/menus/xfce-applications.menu

 <Name>Xfce</Name>
 <DefaultAppDirs />
 <DefaultDirectoryDirs />
 <DefaultMergeDirs />
 <Include>
  <Category>X-Xfce-Toplevel</Category>
 </Include>
 <MergeFile type="parent">/etc/xdg/menus/xfce-applications.menu</MergeFile>
 <Menu>
  <Name>Preferences</Name>
  <Directory>xfce-settings.directory</Directory>
  <Layout>
   <Merge type="menus" />
   <Filename>xfce-settings-manager.desktop</Filename>
   <Separator />
   <Filename>alacarte.desktop</Filename>
   <Filename>arandr.desktop</Filename>
   <Filename>blueman-manager.desktop</Filename>
   <Filename>bluetooth-wizard.desktop</Filename>
   <Filename>ccsm.desktop</Filename>
   <Filename>credentials-preferences.desktop</Filename>
   <Filename>deja-dup-preferences.desktop</Filename>
   <Filename>exo-preferred-applications.desktop</Filename>
   <Filename>flash-player-properties.desktop</Filename>
   <Filename>gnome-disks.desktop</Filename>
   <Filename>gtk-theme-config.desktop</Filename>
   <Filename>gufw.desktop</Filename>
   <Filename>ibus-setup.desktop</Filename>
   <Filename>im-config.desktop</Filename>
   <Filename>indicator-keylock.desktop</Filename>
   <Filename>language-selector.desktop</Filename>
   <Filename>light-locker-settings.desktop</Filename>
   <Filename>menulibre.desktop</Filename>
   <Filename>mugshot.desktop</Filename>
   <Filename>network.desktop</Filename>
   <Filename>nm-connection-editor.desktop</Filename>
   <Filename>onboard-settings.desktop</Filename>
   <Filename>openjdk-7-policytool.desktop</Filename>
   <Filename>panel-preferences.desktop</Filename>
   <Filename>seahorse.desktop</Filename>
   <Filename>shares.desktop</Filename>
   <Filename>software-properties-drivers.desktop</Filename>
   <Filename>software-properties-gtk.desktop</Filename>
   <Filename>synaptic.desktop</Filename>
   <Filename>system-config-printer.desktop</Filename>
   <Filename>thunar-settings.desktop</Filename>
   <Filename>thunar-volman-settings.desktop</Filename>
   <Filename>time.desktop</Filename>
   <Filename>ubuntu-software-center.desktop</Filename>
   <Filename>update-manager.desktop</Filename>
   <Filename>usb-creator-gtk.desktop</Filename>
   <Filename>users.desktop</Filename>
   <Filename>xdiagnose.desktop</Filename>
   <Filename>xfce-backdrop-settings.desktop</Filename>
   <Filename>xfce-display-settings.desktop</Filename>
   <Filename>xfce-keyboard-settings.desktop</Filename>
   <Filename>xfce-mouse-settings.desktop</Filename>
   <Filename>xfce-session-settings.desktop</Filename>
   <Filename>xfce-ui-settings.desktop</Filename>
   <Filename>xfce-wm-settings.desktop</Filename>
   <Filename>xfce-wmtweaks-settings.desktop</Filename>
   <Filename>xfce-workspaces-settings.desktop</Filename>
   <Filename>xfce-xfcalendar-settings.desktop</Filename>
   <Filename>xfce4-accessibility-settings.desktop</Filename>
   <Filename>xfce4-mime-settings.desktop</Filename>
   <Filename>xfce4-notifyd-config.desktop</Filename>
   <Filename>xfce4-power-manager-settings.desktop</Filename>
   <Filename>xfce4-settings-editor.desktop</Filename>
   <Filename>xscreensaver-properties.desktop</Filename>
   <Merge type="files" />
  </Layout>
 </Menu>

Result:

 <Layout>
  <Merge type="menus" />
  <Menuname>Preferences</Menuname>
  <Filename>xfce4-run.desktop</Filename>
  <Separator />
  <Filename>exo-terminal-emulator.desktop</Filename>
  <Filename>exo-file-manager.desktop</Filename>
  <Filename>exo-mail-reader.desktop</Filename>
  <Filename>exo-web-browser.desktop</Filename>
  <Separator />
  <Menuname>Preferences</Menuname>
  <Separator />
  <Menuname>wine-wine</Menuname>
  <Menuname>Graphics</Menuname>
  <Menuname>Accessories</Menuname>
  <Menuname>Network</Menuname>
  <Menuname>Multimedia</Menuname>
  <Menuname>Education</Menuname>
  <Menuname>Office</Menuname>
  <Menuname>Other</Menuname>
  <Menuname>Development</Menuname>
  <Menuname>System</Menuname>
  <Separator />
  <Menuname>Games</Menuname>
  <Filename>xfce4-about.desktop</Filename>
  <Filename>xfce4-session-logout.desktop</Filename>
  <Merge type="files" />
 </Layout>
</Menu>

[OmegaPhil (omegaphil)]

Thanks for the workaround - confirm this also happens in here in Debian Testing / XFCE 4.10.

[Sean Davis (bluesabre)]

I've committed a fix for this in trunk.

[OmegaPhil (omegaphil)]

I have tested this and I can confirm menulibre and alacarte both start up fine after menulibre makes its first change.

menulibre does nuke the menu on its first save, but that is unrelated and I'll report it separately.

[Chris Halse Rogers (raof)]

Hello maxnax, or anyone else affected,

Accepted menulibre into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/menulibre/2.0.4-1~ubuntu14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Sean Davis (bluesabre)]

Verified with menulibre 2.0.4 in trusty-proposed. Run logs below.

http://paste.ubuntu.com/7840031/

[Adam Conrad (adconrad)]

The verification of the Stable Release Update for menulibre has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Michael MacEachern (maceach-b)]

I'm actually having this issue in Xubuntu 17.04. Has this fix not progressed to 17.04?