MeMaker crashes if last theme AND default theme is missing

Bug #181946 reported by Gryc Ueusp on 2008-01-11
4
Affects Status Importance Assigned to Milestone
MeMaker
Wishlist
Unassigned

Bug Description

If the last theme loaded is missing and cocoHead is missing as well, memaker crashes with:
Theme to load was not found. Was it deleted?
Falling back to default theme...
Traceback (most recent call last):
  File "/home/gryc/memaker/trunk-bzr/src/memaker.py", line 440, in <module>
    app = MeMakerGui()
  File "/home/gryc/memaker/trunk-bzr/src/memaker.py", line 196, in __init__
    self.loadFeatures(themeToLoad)
  File "/home/gryc/memaker/trunk-bzr/src/memaker.py", line 316, in loadFeatures
    for items in (os.listdir(locationTheme)):
OSError: [Errno 2] No such file or directory: '../themes/cocoHead/Head/'

We need one more fallback, perhaps to the first theme it can find, and if it cant find that, load nothing and leave the selector as the "get more themes" link.

Andrew (and471) wrote :

If it can't find any themes, we need, maybe, to load in the left hand preview pane probably an images saing 'No themes can be found click Download Link...' etc.

encompass (encompass) on 2008-01-16
Changed in memaker:
status: New → Confirmed
importance: Undecided → Wishlist
encompass (encompass) wrote :

The system comes with one featured theme that is in a place that no one but root can delete. I don't see why we actually need this as I think it would be important to have a theme at all times. I hate it when you get a program that needs extra stuff that you have no idea where to get more.
A perfect example is UltraStar, if I am not mistaken it doesn't come with any songs... You have to have something or people don't like it, and get a VERY bad first impression.
Of course I COULD have the system do what you ask. What does everyone else feel?

Gryc Ueusp (gryc-ueusp) wrote :

Well, the thing is, it crashes even if there are other themes available.
Its not that it shouldnt have any themes by default, it's that there are themes available to it, but doesnt fall back to them.

Vik Reykja (vikreykja) wrote :

I added a fix for this. It will look for, in order:

* last theme used
* default theme (cocohead)
* first theme found
* none

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers