Improve a few strings

Bug #317856 reported by Milan Bouchet-Valat
2
Affects Status Importance Assigned to Milestone
Media Applet
Fix Committed
Medium
khristo

Bug Description

Very nice tool!

I'd recommend you improve a few strings, though:
- size measures should be translatable: byte, KB, MB, GB, are not the same in every language. Also, there's a debate about using MB or MiB - that's a long story (have a look at Wikipedia). For now Nautilus seems to be using MiB, so you may want to do the same for consistency's sake.

- help translators with a gettext comment for "Unknown" (in src/media_device.vala:get_name() ): e.g. in French we need to known whether it's masculine or feminine. So knowing we're talking about the name of the device will avoid errors and approximations (I've just fixed one).

- in the "device added" notification, you show something such as "A dvd video "MATRIX" has been added to your system". This is quite strange. I'd rather say "A DVD video has been added to your system: "MATRIX"."
And I'd even remove the idea of the "system" because we don't care at all about it: ""A DVD video has been added: "MATRIX". An even better approach would be to detect whether we're speaking about a disk/card or a device, and replace added by inserted or connected depending on that (for future work... ;-) ).

- in the same notification, note that "dvd" is not correct, nor is "Cd-Rom": the right string is "DVD", "CD-ROM" and the like. But can't you get these descriptions directly from GIO?

Hope this helps, and keep up the good work!

Changed in media-applet:
assignee: nobody → christian-martellini
importance: Undecided → Medium
Revision history for this message
khristo (christian-martellini) wrote : Re: [Bug 317856] [NEW] Improve a few strings

2009/1/16 Milan <email address hidden>

> Public bug reported:
>
> Very nice tool!
>
Thanks :)

>
> I'd recommend you improve a few strings, though:
> - size measures should be translatable: byte, KB, MB, GB, are not the same
> in every language. Also, there's a debate about using MB or MiB - that's a
> long story (have a look at Wikipedia). For now Nautilus seems to be using
> MiB, so you may want to do the same for consistency's sake.
>
> - help translators with a gettext comment for "Unknown" (in
> src/media_device.vala:get_name() ): e.g. in French we need to known
> whether it's masculine or feminine. So knowing we're talking about the
> name of the device will avoid errors and approximations (I've just fixed
> one).
>
> - in the "device added" notification, you show something such as "A dvd
> video "MATRIX" has been added to your system". This is quite strange. I'd
> rather say "A DVD video has been added to your system: "MATRIX"."
> And I'd even remove the idea of the "system" because we don't care at all
> about it: ""A DVD video has been added: "MATRIX". An even better approach
> would be to detect whether we're speaking about a disk/card or a device, and
> replace added by inserted or connected depending on that (for future work...
> ;-) ).
>

Thanks Milan for your bug report and your good suggestions. I will work on
strings and fix all this problems before 0.4 release.

> - in the same notification, note that "dvd" is not correct, nor is "Cd-
> Rom": the right string is "DVD", "CD-ROM" and the like. But can't you
> get these descriptions directly from GIO?
>
> Maybe yes... I will take a look..

>
> Hope this helps, and keep up the good work!
>
>
Cheers,
Christian

Changed in media-applet:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.