gcc 4.7+: missing unistd.h includes

[Jakob Gruber]

Using gcc 4.7, compilation fails due to missing includes in common/common.cc, server/thread.cc.
See http://gcc.gnu.org/gcc-4.7/porting_to.html.

Making all in common
make[2]: Entering directory `/build/src/me-tv-1.4.0.10/common'
g++ -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/glibmm-2.4 -I/usr/lib/glibmm-2.4/include -I/usr/include/sigc++-2.0 -I/usr/lib/sigc++-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/giomm-2.4 -I/usr/lib/giomm-2.4/include -I/usr/include/libxml++-2.6 -I/usr/lib/libxml++-2.6/include -I/usr/include/libxml2 -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -D__KERNEL_STRICT_NAMES -MT common.o -MD -MP -MF .deps/common.Tpo -c -o common.o common.cc
g++ -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/glibmm-2.4 -I/usr/lib/glibmm-2.4/include -I/usr/include/sigc++-2.0 -I/usr/lib/sigc++-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/giomm-2.4 -I/usr/lib/giomm-2.4/include -I/usr/include/libxml++-2.6 -I/usr/lib/libxml++-2.6/include -I/usr/include/libxml2 -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -D__KERNEL_STRICT_NAMES -MT client.o -MD -MP -MF .deps/client.Tpo -c -o client.o client.cc
common.cc: In function 'void write_string(int, const Glib::ustring&)':
common.cc:106:17: error: '::write' has not been declared
common.cc: In function 'Glib::ustring read_string(int)':
common.cc:125:24: error: '::read' has not been declared

[Peter (f-petere)]

3.2.0-4-amd64 #1 SMP Debian 3.2.32-1 x86_64 GNU/Linux
gcc 4:4.7.2-1
me-tv-1.4.0.10

$aclocal
$autoheader
$ automake
configure.ac:6: required file `./install-sh' not found
configure.ac:6: `automake --add-missing' can install `install-sh'
configure.ac:6: required file `./missing' not found
configure.ac:6: `automake --add-missing' can install `missing'
client/Makefile.am: required file `./depcomp' not found
client/Makefile.am: `automake --add-missing' can install `depcomp'
$automake --add-missing
$autoconf
$./configure
Configure summary:
 Source code location .......: .
 Compiler ...................: gcc
 Compiler flags .............: -g -O2
 Enable compile warnings ....: minimum
 Enable more warnings .......: no
 Extra Compiler Warnings ....: -g -O2 -Wall -Wno-unused
 Debug support ..............: no
 Installing into prefix .....: /usr/local
Type make to build Me TV 1.4.0.10
$ make
make all-recursive
make[1]: Entering directory `/home/brother/Develop/src/me-tv-1.4.0.10'
Making all in common
make[2]: Entering directory `/build/src/me-tv-1.4.0.10/common'
g++ -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/glibmm-2.4 -I/usr/lib/x86_64-linux-gnu/glibmm-2.4/include -I/usr/include/sigc++-2.0 -I/usr/lib/x86_64-linux-gnu/sigc++-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/giomm-2.4 -I/usr/lib/x86_64-linux-gnu/giomm-2.4/include -I/usr/include/libxml2 -I/usr/include/libxml++-2.6 -I/usr/lib/libxml++-2.6/include -g -O2 -MT common.o -MD -MP -MF .deps/common.Tpo -c -o common.o common.cc
common.cc: In function ‘void write_string(int, const Glib::ustring&)’:
common.cc:106:23: error: ‘::write’ has not been declared
common.cc: In function ‘Glib::ustring read_string(int)’:
common.cc:125:27: error: ‘::read’ has not been declared
make[2]: *** [common.o] Error 1
make[2]: Leaving directory `/build/src/me-tv-1.4.0.10/common'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/build/src/me-tv-1.4.0.10'
make: *** [all] Error 2

[Diego Elio Pettenò (flameeyes)]

Portage 2.2.0_alpha149 (default/linux/amd64/10.0, gcc-4.7.2-asneeded, glibc-2.17, 3.5.4-hardened-r1 x86_64)
=================================================================
System uname: Linux-3.5.4-hardened-r1-x86_64-AMD_Opteron-TM-_Processor_6272-with-gentoo-2.2
Timestamp of tree: Sun, 30 Dec 2012 00:00:01 +0000
ld GNU ld (GNU Binutils) 2.23.1
app-shells/bash: 4.2_p39-r1
dev-java/java-config: 2.1.12-r1
dev-lang/python: 2.7.3-r3, 3.2.3-r2
dev-util/cmake: 2.8.10.2
dev-util/pkgconfig: 0.27.1
sys-apps/baselayout: 2.2
sys-apps/openrc: 0.11.8
sys-apps/sandbox: 2.6
sys-devel/autoconf: 2.13, 2.69
sys-devel/automake: 1.11.6, 1.12.6
sys-devel/binutils: 2.23.1
sys-devel/gcc: 4.7.2
sys-devel/gcc-config: 1.8
sys-devel/libtool: 2.4.2
sys-devel/make: 3.82-r4
sys-kernel/linux-headers: 3.7 (virtual/os-headers)
sys-libs/glibc: 2.17
Repositories: gentoo tbamd64
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
DISTDIR="/var/cache/portage/distfiles"
FCFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles merge-sync news parallel-fetch protect-owned sandbox sfperms strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
GENTOO_MIRRORS="http://ftp.ucsb.edu/pub/mirrors/linux/gentoo/ http://gentoo.mirrors.hoobly.com/ http://gentoo.llarian.net/"
LANG="en_US.utf8"
LC_ALL="C"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j24"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/tmp"
PORTDIR="/var/cache/tinderbox/tree"
PORTDIR_OVERLAY="/root/overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowex acl amd64 berkdb bzip2 cli cracklib crypt cups cxx doc dri emacs ffmpeg fortran gnutls gpm iconv icu intl introspection ipv6 mmx modules mudflap multilib ncurses nls nptl openmp pam pax_kernel pcre pdf plasma pppd qt3support readline semantic-desktop session snmp sse sse2 sse3 sse4 ssl ssse3 tcmalloc tcpd udev unicode vhosts zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty...

[Lordvan-l (lordvan-l)]

Found an upstream bug:
https://bugs.launchpad.net/me-tv/+bug/1020690

[Dirtyepic (dirtyepic)]

Fixed.

http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/me-tv/me-tv-1.4.0.10.ebuild?rev=1.2&view=markup
http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/me-tv/me-tv-1.4.0.10.ebuild?r1=1.1&r2=1.2
http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/me-tv/files/me-tv-1.4.0.10-gcc47.patch?rev=1.1&view=markup