masakari

Handle host notification without host status

Bug #1960619 reported by Mitya Eremeev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
masakari
Fix Released
Undecided
Mitya Eremeev

Bug Description

If an user sends host notification without host status:
openstack notification create COMPUTE_HOST <host> <date> '{"event": "STOPPED"}'

Logging registers silly error like object None has not method 'upper' and notification gets status 'running', host is set in maintenance status.
It's impossible to set manually host status to non-maintanence until there are host-related running notifications.
Running notifications are expired in 24 hours by default.

Mitya Eremeev (mitos)
Changed in masakari:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/masakari/+/828862

Mitya Eremeev (mitos)
Changed in masakari:
assignee: nobody → Mitya Eremeev (mitos)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari (master)

Reviewed: https://review.opendev.org/c/openstack/masakari/+/828862
Committed: https://opendev.org/openstack/masakari/commit/0837d7787c1be35df4b4330dbe6cdd2c160a69ab
Submitter: "Zuul (22348)"
Branch: master

commit 0837d7787c1be35df4b4330dbe6cdd2c160a69ab
Author: Mitya_Eremeev <email address hidden>
Date: Fri Feb 11 14:36:12 2022 +0300

    Handle host notification without host status

    If an user sends host notification without host status:
    openstack notification create COMPUTE_HOST <host> <date> '{"event": "STOPPED"}'
    logging registers silly error like object None has not method 'upper' and
    notification gets status 'running', host is set in maintenance status.
    It's impossible to set manually host status to non-maintanence
    until there are host-related running notifications.
    Running notifications are expired in 24 hours by default.
    The patch makes engine to set 'ignore' status for such
    notifications.

    Closes-Bug: 1960619
    Change-Id: Id873b3300b6de49082805654c85414a8868dd925

Changed in masakari:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/masakari/+/861299

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/masakari/+/861300

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/masakari/+/861301

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/masakari/+/861302

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/masakari/+/861299
Committed: https://opendev.org/openstack/masakari/commit/c813fa9622d4f41d8de542237368a5f34e6bc371
Submitter: "Zuul (22348)"
Branch: stable/zed

commit c813fa9622d4f41d8de542237368a5f34e6bc371
Author: Mitya_Eremeev <email address hidden>
Date: Fri Feb 11 14:36:12 2022 +0300

    Handle host notification without host status

    If an user sends host notification without host status:
    openstack notification create COMPUTE_HOST <host> <date> '{"event": "STOPPED"}'
    logging registers silly error like object None has not method 'upper' and
    notification gets status 'running', host is set in maintenance status.
    It's impossible to set manually host status to non-maintanence
    until there are host-related running notifications.
    Running notifications are expired in 24 hours by default.
    The patch makes engine to set 'ignore' status for such
    notifications.

    Closes-Bug: 1960619
    Change-Id: Id873b3300b6de49082805654c85414a8868dd925
    (cherry picked from commit 0837d7787c1be35df4b4330dbe6cdd2c160a69ab)

tags: added: in-stable-zed
tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/masakari/+/861300
Committed: https://opendev.org/openstack/masakari/commit/f844b8f48e75c0853b19324d000a021c5f02d385
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit f844b8f48e75c0853b19324d000a021c5f02d385
Author: Mitya_Eremeev <email address hidden>
Date: Fri Feb 11 14:36:12 2022 +0300

    Handle host notification without host status

    If an user sends host notification without host status:
    openstack notification create COMPUTE_HOST <host> <date> '{"event": "STOPPED"}'
    logging registers silly error like object None has not method 'upper' and
    notification gets status 'running', host is set in maintenance status.
    It's impossible to set manually host status to non-maintanence
    until there are host-related running notifications.
    Running notifications are expired in 24 hours by default.
    The patch makes engine to set 'ignore' status for such
    notifications.

    Closes-Bug: 1960619
    Change-Id: Id873b3300b6de49082805654c85414a8868dd925
    (cherry picked from commit 0837d7787c1be35df4b4330dbe6cdd2c160a69ab)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/masakari/+/861301
Committed: https://opendev.org/openstack/masakari/commit/a5b7564f4453e7ec7df4021a852eb40b0bd631ca
Submitter: "Zuul (22348)"
Branch: stable/xena

commit a5b7564f4453e7ec7df4021a852eb40b0bd631ca
Author: Mitya_Eremeev <email address hidden>
Date: Fri Feb 11 14:36:12 2022 +0300

    Handle host notification without host status

    If an user sends host notification without host status:
    openstack notification create COMPUTE_HOST <host> <date> '{"event": "STOPPED"}'
    logging registers silly error like object None has not method 'upper' and
    notification gets status 'running', host is set in maintenance status.
    It's impossible to set manually host status to non-maintanence
    until there are host-related running notifications.
    Running notifications are expired in 24 hours by default.
    The patch makes engine to set 'ignore' status for such
    notifications.

    Closes-Bug: 1960619
    Change-Id: Id873b3300b6de49082805654c85414a8868dd925
    (cherry picked from commit 0837d7787c1be35df4b4330dbe6cdd2c160a69ab)

tags: added: in-stable-xena
tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/masakari/+/861302
Committed: https://opendev.org/openstack/masakari/commit/e3f6e78847568121529d24d1fd71b166cee965af
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit e3f6e78847568121529d24d1fd71b166cee965af
Author: Mitya_Eremeev <email address hidden>
Date: Fri Feb 11 14:36:12 2022 +0300

    Handle host notification without host status

    If an user sends host notification without host status:
    openstack notification create COMPUTE_HOST <host> <date> '{"event": "STOPPED"}'
    logging registers silly error like object None has not method 'upper' and
    notification gets status 'running', host is set in maintenance status.
    It's impossible to set manually host status to non-maintanence
    until there are host-related running notifications.
    Running notifications are expired in 24 hours by default.
    The patch makes engine to set 'ignore' status for such
    notifications.

    Closes-Bug: 1960619
    Change-Id: Id873b3300b6de49082805654c85414a8868dd925
    (cherry picked from commit 0837d7787c1be35df4b4330dbe6cdd2c160a69ab)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/masakari 11.0.3

This issue was fixed in the openstack/masakari 11.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/masakari 12.0.2

This issue was fixed in the openstack/masakari 12.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/masakari 13.0.2

This issue was fixed in the openstack/masakari 13.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/masakari 14.0.1

This issue was fixed in the openstack/masakari 14.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/masakari 15.0.0.0rc1

This issue was fixed in the openstack/masakari 15.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.