Masakari horizon plugin does not follow OPENSTACK_ENDPOINT_TYPE

[masterpe]

The Horizon Masakari dashboard does not follow the settings OPENSTACK_ENDPOINT_TYPE.

It does not use the OPENSTACK_ENDPOINT_TYPE setting and only uses the public endpoint.

Openstack-ansible project used the internal endpoint for the internal communication with a http communication path.

There the behavior is different then the rest of the platform, you can get issues.

[Luis (luis-ramirez)]

The service is deployed, up & running.

- If the Public endpoint is removed the service could not be accessible through the other 2 end-points.
- The horizon logs show calls to the Public-endpoint.
- Using the OpenStack CLI is working fine; you can manage/operate the service.
- Do you have a workaround to try to avoid the use of the public-endpoint?

[masterpe (michiel-y)]

I was talking to jrosser about this[1] and he pointed out that masakaridashboard does not use OPENSTACK_ENDPOINT_TYPE on the openstack_connection[2] function.

For example octavia_dashboard[3] uses this setting, I would expect that masakari-dashboard does the same. Personally I don't know how to fix this.

[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ansible/%23openstack-ansible.2020-08-10.log.html#t2020-08-10T11:24:03
[2] https://github.com/openstack/masakari-dashboard/blob/master/masakaridashboard/api/api.py#L35-L44
[3] https://github.com/openstack/octavia-dashboard/blob/master/octavia_dashboard/api/rest/lbaasv2.py#L50

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/745882

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/745882
Committed: https://git.openstack.org/cgit/openstack/masakari-dashboard/commit/?id=1dde9dc923bf0e8a87c06524afc3f0c978d01613
Submitter: Zuul
Branch: master

commit 1dde9dc923bf0e8a87c06524afc3f0c978d01613
Author: Michiel Piscaer <email address hidden>
Date: Wed Aug 12 15:05:17 2020 +0200

    Add OPENSTACK_ENDPOINT_TYPE to the connection

    Pass interface to honor 'OPENSTACK_ENDPOINT_TYPE' so it can have multiple endpoints,
    without this it only communicate with the public endpoint.

    Closes-Bug: #1891230
    Change-Id: I7caf9170d63eff388af5d690dd6b054188752381

[Radosław Piliszek (yoctozepto)]

TODO(myself): this should be targeted at masakari-dashboard instead

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/754383
Committed: https://git.openstack.org/cgit/openstack/masakari-dashboard/commit/?id=27cdc345ddfddf7090cc3c72b08231f5ae285e36
Submitter: Zuul
Branch: stable/ussuri

commit 27cdc345ddfddf7090cc3c72b08231f5ae285e36
Author: Michiel Piscaer <email address hidden>
Date: Wed Aug 12 15:05:17 2020 +0200

    Add OPENSTACK_ENDPOINT_TYPE to the connection

    Pass interface to honor 'OPENSTACK_ENDPOINT_TYPE' so it can have multiple endpoints,
    without this it only communicate with the public endpoint.

    Closes-Bug: #1891230
    Change-Id: I7caf9170d63eff388af5d690dd6b054188752381
    (cherry picked from commit 1dde9dc923bf0e8a87c06524afc3f0c978d01613)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/754384
Committed: https://git.openstack.org/cgit/openstack/masakari-dashboard/commit/?id=2329aad68534b66f588aa79506a9ed73cc5eca27
Submitter: Zuul
Branch: stable/train

commit 2329aad68534b66f588aa79506a9ed73cc5eca27
Author: Michiel Piscaer <email address hidden>
Date: Wed Aug 12 15:05:17 2020 +0200

    Add OPENSTACK_ENDPOINT_TYPE to the connection

    Pass interface to honor 'OPENSTACK_ENDPOINT_TYPE' so it can have multiple endpoints,
    without this it only communicate with the public endpoint.

    Closes-Bug: #1891230
    Change-Id: I7caf9170d63eff388af5d690dd6b054188752381
    (cherry picked from commit 1dde9dc923bf0e8a87c06524afc3f0c978d01613)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/754385
Committed: https://git.openstack.org/cgit/openstack/masakari-dashboard/commit/?id=0421f11a1802fbde85c8fe14fa6c9739646d9337
Submitter: Zuul
Branch: stable/stein

commit 0421f11a1802fbde85c8fe14fa6c9739646d9337
Author: Michiel Piscaer <email address hidden>
Date: Wed Aug 12 15:05:17 2020 +0200

    Add OPENSTACK_ENDPOINT_TYPE to the connection

    Pass interface to honor 'OPENSTACK_ENDPOINT_TYPE' so it can have multiple endpoints,
    without this it only communicate with the public endpoint.

    Closes-Bug: #1891230
    Change-Id: I7caf9170d63eff388af5d690dd6b054188752381
    (cherry picked from commit 1dde9dc923bf0e8a87c06524afc3f0c978d01613)