Instances which are in shelved, paused and rescued states are not evacuated

[Abhishek Kekane]

As of now, for host failure recovery flow instances which are in shelved, paused and rescued state are ignored and those instances remains on failed host forever. As per discussion in masakari meeting [1] such instances should be reset to error state before evacuation and after evacuation those instances should be stopped (shutdown) explicitly.

[1] http://eavesdrop.openstack.org/meetings/masakari/2017/masakari.2017-05-23-04.00.log.html#l-74

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/469029

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/469029
Committed: https://git.openstack.org/cgit/openstack/masakari/commit/?id=4173aaf0396890ba47ce9c34aa38bf87945e9144
Submitter: Jenkins
Branch: master

commit 4173aaf0396890ba47ce9c34aa38bf87945e9144
Author: dineshbhor <email address hidden>
Date: Fri May 26 16:00:53 2017 +0530

    Make provision to evacuate all instances

    As of now host failure workflow was evacuating instances which were
    having vm_state as active, stopped, error and resize. It was ignoring
    other vm_states such as shelved, rescued, paused and suspended. Made
    provision to evacuate instances which are having vm_states such as
    shelved, rescued, paused and suspended by changing its vm_state to
    error and after evacuating those instances will be stopped.

    NOTE:
    On master if the instance is in error or resized state then after
    recovery it was becoming active. With this patch error instances
    will be stopped and then set to error after recovery. For resized
    instance if it's previous power_state is 4(SHUTDOWN) then we can
    say that before failure the instance was is stopped state and then
    it was resized so masakari will stop that instance to maintain
    consistency of instance states as the instance was not fully
    resized(resize operation was not confirmed). Resized instance which
    was in active state before failure will become active again after
    recovery.

    Closes-Bug: #1693731
    Closes-Bug: #1692435
    Closes-Bug: #1690995
    Closes-Bug: #1690768
    Change-Id: I134e8b6ee7315935bd8ce418ef6241be0b9450b3