Masakari is not synced with upper-contraints of global requirements

Bug #1662408 reported by Abhishek Kekane
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
masakari
Fix Released
High
Abhishek Kekane

Bug Description

Following masakari test is failing on latest master as invalid version of jsonchema library (2.6.0) is getting installed.

======================================================================
FAIL: masakari.tests.unit.test_api_validation.PatternPropertiesTestCase.test_validate_patternProperties_fails
tags: worker-1
----------------------------------------------------------------------
Traceback (most recent call last):
  File "masakari/tests/unit/test_api_validation.py", line 249, in test_validate_patternProperties_fails
    expected_detail=detail)
  File "masakari/tests/unit/test_api_validation.py", line 105, in check_validation_error
    'Exception details did not match expected')
  File "/opt/stack/masakari/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/opt/stack/masakari/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = "Additional properties are not allowed ('__' was unexpected)"
actual = "'__' does not match any of the regexes: '^[a-zA-Z0-9]{1,10}$'"
: Exception details did not match expected
Ran 638 tests in 14.152s (-0.154s)
FAILED (id=6, failures=1, skips=3)
error: testr failed (1)
ERROR: InvocationError: '/opt/stack/masakari/.tox/py27/bin/python setup.py test --slowest --testr-args='

This new version of jsonschema library is tagged 10 days before. Earlier it was installing jsonschema library version 2.5.1 (same as mentioned in upper-constraints.txt of openstack/requirements [1])
In requirement.txt of masakari and nova jsconschema version is mentioned as,
jsonschema!=2.5.0,<3.0.0,>=2.0.0

So in-case of nova it is installing jsonschema 2.5.1 as mentioned in upper-constraints.txt but for masakari it is installing 2.6.0 as it is not syncing with openstack/requirements

If I make below change in masakari/requirements.txt then all tests are passing.
jsonschema!=2.5.0,!=2.6.0,<3.0.0,>=2.0.0

[1] https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L173

Changed in masakari:
assignee: nobody → Abhishek Kekane (abhishek-kekane)
Changed in masakari:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari (master)

Fix proposed to branch: master
Review: https://review.openstack.org/430106

Changed in masakari:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari (master)

Reviewed: https://review.openstack.org/430106
Committed: https://git.openstack.org/cgit/openstack/masakari/commit/?id=7645ab489d8a815241b2a9054e3d2658728b4a80
Submitter: Jenkins
Branch: master

commit 7645ab489d8a815241b2a9054e3d2658728b4a80
Author: Abhishek Kekane <email address hidden>
Date: Tue Feb 7 09:52:36 2017 +0530

    Sync tox environment with upper-constraint of requirements

    Added upper-constraints reference while installing requirements
    in tox environment.

    Change-Id: I4732d1128aefb57af1598a2c704e86c1d9509b2d
    Closes-Bug: #1662408

Changed in masakari:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.