Gate jobs are failing due to removal of service_catalog from novaclient

[Dinesh Bhor]

In patch [1], service_catalog module was removed from python-novaclient.
As this module is still referred by masakari, nothing is working as it fails to start masakari service.

Failed to import test module: masakari.tests.unit.engine.drivers.taskflow.test_host_failure_flow
 Traceback (most recent call last):
 File "/home/jenkins/workspace/gate-masakari-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/unittest2/loader.py", line 456, in _find_test_path
  module = self._get_module_from_name(name)
 File "/home/jenkins/workspace/gate-masakari-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/unittest2/loader.py", line 395, in _get_module_from_name
  __import__(name)
 File "masakari/tests/unit/engine/drivers/taskflow/test_host_failure_flow.py", line 23, in <module>
  from masakari.compute import nova
 File "masakari/compute/nova.py", line 28, in <module>
  from novaclient import service_catalog
 ImportError: cannot import name service_catalog

Refer to the gate job log messages to see the error:
http://logs.openstack.org/38/407538/3/check/gate-masakari-python27-ubuntu-xenial/6f11444/console.html.gz

[1] https://review.openstack.org/#/c/408728/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/415863

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/415863
Committed: https://git.openstack.org/cgit/openstack/masakari/commit/?id=1c2fc1bfb407b1d8ea2d9809955617c853a075c1
Submitter: Jenkins
Branch: master

commit 1c2fc1bfb407b1d8ea2d9809955617c853a075c1
Author: dineshbhor <email address hidden>
Date: Mon Dec 26 18:02:55 2016 +0530

    Fix failing gate jobs due to removal of nova_client.service_catalog

    Nova community has removed support of HTTPClient [1] thus they have
    removed service_catalog as well. Services which are going to call nova
    has to use SessionClient only. It is recommended to use
    keystoneauth1.service_catalog and not nova_client.service_catalog as it
    is removed in commit [1].

    We are already using SessionClient. This patch uses the service_catalog
    from keystoneauth1.

    NOTE:
    novaclient will be called only with admin_endpoint and privileged_user.
    So there is no need to form url for normal user. So removed unused code
    from masakari.compute.nova.py

    [1] 2e5576dafc21906a95196054f85c80b57c48663a

    Closes-Bug: #1653052
    Change-Id: I2a28eb94e190cd0416d0d7ea56af8f7ca76dbae5