pep8 error in masakari-monitors

Bug #2036529 reported by LeeChunghwan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
masakari-monitors
Invalid
Undecided
Unassigned

Bug Description

./masakarimonitors/hacking/checks.py:75:9: E275 missing whitespace after keyword
    elif(translated_log.match(logical_line) or
        ^
./masakarimonitors/tests/unit/test_hacking.py:25:80: E501 line too long (80 > 79 characters)
    """This class tests the hacking checks in masakarimonitors.hacking.checks by
    passing strings to the check methods like the pycodestyle/flake8 parser
    would.

    The parser loops over each line in the file and then passes the
    parameters to the check method. The parameter names in the check method
    dictate what type of object is passed to the check method.

    The parameter types are::

        logical_line: A processed line with the following modifications:
            - Multi-line statements converted to a single line.
            - Stripped left and right.
            - Contents of strings replaced with "xxx" of same length.
            - Comments removed.
        physical_line: Raw line of text from the input file.
        lines: a list of the raw lines from the input file
        tokens: the tokens that contribute to this logical line
        line_number: line number in the input file
        total_lines: number of lines in the input file
        blank_lines: blank lines before this one
        indent_char: indentation character in this file (" " or "\t")
        indent_level: indentation (with tabs expanded to multiples of 8)
        previous_indent_level: indentation on previous line
        previous_logical: previous logical line
        filename: Path of the file being run through pycodestyle

    When running a test on a check method the return will be False/None if
    there is no violation in the sample input. If there is an error a tuple is
    returned with a position in the line, and a message. So to check the result
    just assertTrue if the check is expected to fail and assertFalse if it
    should pass.
    """

Changed in masakari-monitors:
assignee: nobody → LeeChunghwan (chung00lee)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari-monitors (master)
Changed in masakari-monitors:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on masakari-monitors (master)

Change abandoned by "LeeChunghwan <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/masakari-monitors/+/895775
Reason: duplicate #892786

Changed in masakari-monitors:
status: In Progress → Invalid
assignee: LeeChunghwan (chung00lee) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.