introspective-instance-monitor:Should not use LIBVIRT_DEFAULT_URI in function checkGuests

Bug #1844603 reported by 长孙弘奕 on 2019-09-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
masakari-monitors
Undecided
Unassigned

Bug Description

in masakari-monitors/masakarimonitors/introspectiveinstancemonitor/qemu_utils.py:390
code ` conn = libvirt.open(None) # LIBVIRT_DEFAULT_URI`
will use the environment variable LIBVIRT_DEFAULT_URI.
If I run the masakari-introspective-instance-monitor service in ubuntu 18.04 with `systemctl restart masakari-introspective-instance-monitor`.LIBVIRT_DEFAULT_URI is qemu:///sessoin. and I can not get any domains.
However, in masakari-monitors/masakarimonitors/introspectiveinstancemonitor/instance.py:172,LOG debug tells to use uri with CONF.libvirt.connection_uri. It cost me a lot of time to troubleshooting the problem.
So, I think alter `conn = libvirt.open(None)` to `conn = libvirt.open(CONF.libvirt.connection_uri)` is better.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers