Masakari dashboard should use nova service list for populating host candidates

Bug #1944679 reported by Pavlo Shchelokovskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
masakari-dashboard
Status tracked in Yoga
Train
Fix Committed
Medium
Unassigned
Ussuri
Fix Committed
Medium
Unassigned
Victoria
Fix Committed
Medium
Unassigned
Wallaby
Fix Committed
Medium
Unassigned
Xena
Fix Committed
Medium
Unassigned
Yoga
Fix Released
Medium
Pavlo Shchelokovskyy

Bug Description

Currently masakari-dashboard uses nova hypervisor list api and hypervisor names to populate the lst of candidates when creating a host.

However, masakari itself uses nova service list instead, and validates the input against it as well since https://review.opendev.org/q/I9c591d33f17a8d5950bdb1fc2d686e2301fc6d95

Since hypervisor host name and compute service host are not necessarily the same (the former for example may be full FQDN while latter just a short hostname) this leads to inability to add hosts to segment via Masakar Dashboard, as request is denied by masakari api

Maakari-dashborad should use the same api to retrieve list of host candidate as masakari-api does, namely compute service list.

The slight change will be that the IDs printed next to the candidate name will change too, as the service ID is generally not the same as hypervisor id.

Changed in masakari-dashboard:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
Changed in masakari-dashboard:
status: New → In Progress
Changed in masakari-dashboard:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari-dashboard (master)

Reviewed: https://review.opendev.org/c/openstack/masakari-dashboard/+/810308
Committed: https://opendev.org/openstack/masakari-dashboard/commit/021d1c184e5d87b5b4df5e067954f6f1cb46b6c4
Submitter: "Zuul (22348)"
Branch: master

commit 021d1c184e5d87b5b4df5e067954f6f1cb46b6c4
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Sep 21 17:15:35 2021 +0300

    Use service list instead of hypervisor list

    the host names in them are not necessarily the same,
    and Masakari service itself validates the input against
    the nova service list, not hypervisor list,
    since change I9c591d33f17a8d5950bdb1fc2d686e2301fc6d95 in Masakari.

    Closes-Bug: #1944679
    Change-Id: Id017b91c59aff54435c35d410fcb56a086a732ef

Changed in masakari-dashboard:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari-dashboard (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/masakari-dashboard/+/810884

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari-dashboard (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/masakari-dashboard/+/810884
Committed: https://opendev.org/openstack/masakari-dashboard/commit/fae46199bba14b9d0f746338803fffa898f6532c
Submitter: "Zuul (22348)"
Branch: stable/xena

commit fae46199bba14b9d0f746338803fffa898f6532c
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Sep 21 17:15:35 2021 +0300

    Use service list instead of hypervisor list

    the host names in them are not necessarily the same,
    and Masakari service itself validates the input against
    the nova service list, not hypervisor list,
    since change I9c591d33f17a8d5950bdb1fc2d686e2301fc6d95 in Masakari.

    Closes-Bug: #1944679
    Change-Id: Id017b91c59aff54435c35d410fcb56a086a732ef
    (cherry picked from commit 021d1c184e5d87b5b4df5e067954f6f1cb46b6c4)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari-dashboard (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/masakari-dashboard/+/810885

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari-dashboard (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/masakari-dashboard/+/810885
Committed: https://opendev.org/openstack/masakari-dashboard/commit/a879b6bbfbd17d2a4dbee4c0dde200db7d944631
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit a879b6bbfbd17d2a4dbee4c0dde200db7d944631
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Sep 21 17:15:35 2021 +0300

    Use service list instead of hypervisor list

    the host names in them are not necessarily the same,
    and Masakari service itself validates the input against
    the nova service list, not hypervisor list,
    since change I9c591d33f17a8d5950bdb1fc2d686e2301fc6d95 in Masakari.

    Closes-Bug: #1944679
    Change-Id: Id017b91c59aff54435c35d410fcb56a086a732ef
    (cherry picked from commit 021d1c184e5d87b5b4df5e067954f6f1cb46b6c4)
    (cherry picked from commit fae46199bba14b9d0f746338803fffa898f6532c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari-dashboard (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/masakari-dashboard/+/810888

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari-dashboard (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/masakari-dashboard/+/810888
Committed: https://opendev.org/openstack/masakari-dashboard/commit/57610fce4bc25da2f04fd29d20fd899955782e47
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 57610fce4bc25da2f04fd29d20fd899955782e47
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Sep 21 17:15:35 2021 +0300

    Use service list instead of hypervisor list

    the host names in them are not necessarily the same,
    and Masakari service itself validates the input against
    the nova service list, not hypervisor list,
    since change I9c591d33f17a8d5950bdb1fc2d686e2301fc6d95 in Masakari.

    Closes-Bug: #1944679
    Change-Id: Id017b91c59aff54435c35d410fcb56a086a732ef
    (cherry picked from commit 021d1c184e5d87b5b4df5e067954f6f1cb46b6c4)
    (cherry picked from commit fae46199bba14b9d0f746338803fffa898f6532c)
    (cherry picked from commit a879b6bbfbd17d2a4dbee4c0dde200db7d944631)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari-dashboard (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/masakari-dashboard/+/810889

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari-dashboard (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/masakari-dashboard/+/810889
Committed: https://opendev.org/openstack/masakari-dashboard/commit/93fc60e681a190caecc65fc3e132ec0cd9a671c0
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 93fc60e681a190caecc65fc3e132ec0cd9a671c0
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Sep 21 17:15:35 2021 +0300

    Use service list instead of hypervisor list

    the host names in them are not necessarily the same,
    and Masakari service itself validates the input against
    the nova service list, not hypervisor list,
    since change I9c591d33f17a8d5950bdb1fc2d686e2301fc6d95 in Masakari.

    Closes-Bug: #1944679
    Change-Id: Id017b91c59aff54435c35d410fcb56a086a732ef
    (cherry picked from commit 021d1c184e5d87b5b4df5e067954f6f1cb46b6c4)
    (cherry picked from commit fae46199bba14b9d0f746338803fffa898f6532c)
    (cherry picked from commit a879b6bbfbd17d2a4dbee4c0dde200db7d944631)
    (cherry picked from commit 57610fce4bc25da2f04fd29d20fd899955782e47)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari-dashboard (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/masakari-dashboard/+/810970

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari-dashboard (stable/train)

Reviewed: https://review.opendev.org/c/openstack/masakari-dashboard/+/810970
Committed: https://opendev.org/openstack/masakari-dashboard/commit/f0e829e35364495999bd285ac0d19d1a572eb44e
Submitter: "Zuul (22348)"
Branch: stable/train

commit f0e829e35364495999bd285ac0d19d1a572eb44e
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Sep 21 17:15:35 2021 +0300

    Use service list instead of hypervisor list

    the host names in them are not necessarily the same,
    and Masakari service itself validates the input against
    the nova service list, not hypervisor list,
    since change I9c591d33f17a8d5950bdb1fc2d686e2301fc6d95 in Masakari.

    Closes-Bug: #1944679
    Change-Id: Id017b91c59aff54435c35d410fcb56a086a732ef
    (cherry picked from commit 021d1c184e5d87b5b4df5e067954f6f1cb46b6c4)
    (cherry picked from commit fae46199bba14b9d0f746338803fffa898f6532c)
    (cherry picked from commit a879b6bbfbd17d2a4dbee4c0dde200db7d944631)
    (cherry picked from commit 57610fce4bc25da2f04fd29d20fd899955782e47)
    (cherry picked from commit 93fc60e681a190caecc65fc3e132ec0cd9a671c0)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/masakari-dashboard 5.0.0.0rc2

This issue was fixed in the openstack/masakari-dashboard 5.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/masakari-dashboard 2.0.2

This issue was fixed in the openstack/masakari-dashboard 2.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/masakari-dashboard 3.0.1

This issue was fixed in the openstack/masakari-dashboard 3.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/masakari-dashboard 4.0.1

This issue was fixed in the openstack/masakari-dashboard 4.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/masakari-dashboard 6.0.0.0rc1

This issue was fixed in the openstack/masakari-dashboard 6.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers