Feature request - prevent truncating query in mytop

Bug #956585 reported by Vladislav Vaintroub on 2012-03-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MariaDB
Fix Released
Wishlist
Michael Widenius

Bug Description

Asked by MariaDB user on IRC . He also created a patch for mytop - additional -L option (long queries).

Related branches

Jean Weisbuch (m-jea0-p) wrote :

--- mytop.sh 2012-03-16 00:53:10.418317632 +0100
+++ mytop.sh 2012-03-16 19:20:15.251143868 +0100
@@ -15,6 +15,7 @@
 use 5.005;
 use strict;
 use DBI;
+use Config::IniFiles;
 use Getopt::Long;
 use Socket;
 use List::Util qw(min max);
@@ -75,7 +76,7 @@
 my %config = (
     batchmode => 0,
     color => 1,
- db => 'test',
+ db => '',
     delay => 5,
     filter_user => qr/.?/,
     filter_db => qr/.?/,
@@ -113,6 +114,26 @@
 my $RM_RESET = 0;
 my $RM_NOBLKRD = 3; ## using 4 traps Ctrl-C :-(

+## Try ~/.my.cnf first
+
+my $mycnf = "$ENV{HOME}/.my.cnf";
+
+if (-e $mycnf)
+{
+ my $cfgini = new Config::IniFiles( -file => $mycnf );
+ my @sections = ('client', 'mytop');
+
+ foreach my $section (@sections) {
+ foreach my $param ($cfgini->Parameters ($section))
+ {
+ $config{$param} = $cfgini->val($section, $param) if exists $config{$param};
+ }
+ }
+ ## map database/password onto db/pass (long version gets precedence in .my.cnf)
+ $config{'db'} = $config{'database'} if $config{'database'};
+ $config{'pass'} = $config{'password'} if $config{'password'};
+}
+
 ## Read the user's config file, if it exists.

 my $config = "$ENV{HOME}/.mytop";

Jean Weisbuch (m-jea0-p) wrote :

Diff patch on #2 allow mytop to read informations from ~/.my.cnf like it does in Debian and Ubuntu packaged versions of mytop so you can replace it directly without having to create a ~/.mytop file to put your connection parameters for example.

Elena Stepanova (elenst) on 2012-03-27
Changed in maria:
assignee: nobody → Michael Widenius (monty)
Michael Widenius (monty) wrote :

I have added the original patch to MariaDB 5.3.6
I have added a different patch to read the my.cnf file that relies on my_print_defaults. This way all options files are read, like with all other MariaDB programs.

Thanks for the patches!

Changed in maria:
status: New → In Progress
importance: Undecided → Wishlist
milestone: none → 5.3
Michael Widenius (monty) on 2012-03-27
Changed in maria:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers