xtradb compiler warnings
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MariaDB |
New
|
Undecided
|
Kristian Nielsen |
Bug Description
xtradb in MariaDB has compiler warnings. Official InnoDB has none.
From mariadb-5.1.42:
btr/btr0cur.c:3305: warning: value computed is not used
btr/btr0cur.c:3236: warning: ‘n_not_nulls’ may be used uninitialized in this function
fil/fil0fil.c:3101: warning: pointer targets in passing argument 2 of ‘dict_table_
handler/
log/log0recv.
os/os0file.c:4194: warning: pointer targets in assignment differ in signedness
srv/srv0srv.c:1123: warning: value computed is not used
srv/srv0srv.c:1153: warning: value computed is not used
srv/srv0srv.c:1360: warning: value computed is not used
sync/sync0sync.
From latest bzr code for lp:maria/5.2
warnings for storage/xtradb
btr/btr0btr.c:2871: warning: null argument where non-null required (argument 1)
btr/btr0cur.c:1841: warning: null argument where non-null required (argument 2)
btr/btr0cur.c:1860: warning: null argument where non-null required (argument 1)
btr/btr0cur.c:1967: warning: null argument where non-null required (argument 1)
fil/fil0fil.c:3106: warning: pointer targets in passing argument 2 of 'dict_table_
ibuf/ibuf0ibuf.
ibuf/ibuf0ibuf.
os/os0file.c:4194: warning: pointer targets in assignment differ in signedness
srv/srv0srv.c:1129: warning: value computed is not used
srv/srv0srv.c:1159: warning: value computed is not used
srv/srv0srv.c:1366: warning: value computed is not used
storage/
Changed in maria: | |
milestone: | none → 5.1 |
In MariaDB, we maintain a file support- files/compiler_ warnings. supp. This file valgrind. supp, it is a list of compiler warnings to
is similar to mysql-test/
ignore.
This is a compromise between on the one hand eliminating all warnings (so new
ones are easy to spot), and on the other hand not unnecessarily convoluting
the code in cases where a compiler produces a false warning that requires
unnatural code rewrite to eliminate.
The Buildbot setup parses this .supp file to eliminate warnings to be files/ccfilter which can be used to do
suppressed. There is a script support-
similar warning suppressions in a local build.
As far as I can see, the mentioned warnings are already suppressed, and
Buildbot seems to have no non-suppressed compiler warnings on non-windows
platforms.
Of course, it might be that some warnings are needlessly (or wrongly) warnings. supp
suppressed, and such should be fixed; however, I took this bug report to be
simply that we do not have zero warnings. For zero warnings in MariaDB,
currently the policy is that this requires using the compiler_
file.
(Note that the latest MariaDB 5.1 release is 5.1.47).