Missing define for internal libevent on Debian 4 (Etch)

[Arjen Lentz]

As subject. Also, missing copyright notice for copied BSD defines.

Fix by Antony Curtis. Branch attached, based on 5.1-release tree.

[Arjen Lentz (arjen-lentz)]

Since this bug/fix involves a main source modification, the OurDelta builds of MariaDB 5.1 for Debian 4 have been deferred until this patch is reviewed for the release line.

[Michael Widenius (monty)]

Hi!

>>>>> "Arjen" == Arjen Lentz <email address hidden> writes:

Arjen> Since this bug/fix involves a main source modification, the OurDelta
Arjen> builds of MariaDB 5.1 for Debian 4 have been deferred until this patch
Arjen> is reviewed for the release line.

#ifndef HAVE_TAILQFOREACH
/* These following macros are copied from BSD sys/queue.h
   Copyright (c) 1991, 1993, The Regents of the University of California.
   All rights reserved.
*/

#define TAILQ_EMPTY(head) ((head)->tqh_first == NULL)

I checked the BSD code and the macros has similar names, but
implementation is different.

As the names as such are not copyrightable and we don't strictly need the
above comment but I agree that it's good to give credits where credits
is due, so lets keep them.

I also checked that the README file contains the Copyright text
required by the BSD code, so we are in the clear regarding this.

Arjen, ok to push your fix to the 5.1-release tree.

Regards,
Monty

[Arjen Lentz (arjen-lentz)]

Hi Monty

We should also have -Wimplicit, as it would have caught the problem
during the compile phase rather than chucking a link (missing symbol)
error.
I'd love to see MySQL compiled cleanly with -pedantic.

On 03/11/2009, at 12:59 AM, Michael Widenius wrote:
>>>>>> "Arjen" == Arjen Lentz <email address hidden> writes:
>
> Arjen> Since this bug/fix involves a main source modification, the
> OurDelta
> Arjen> builds of MariaDB 5.1 for Debian 4 have been deferred until
> this patch
> Arjen> is reviewed for the release line.
>
> #ifndef HAVE_TAILQFOREACH
> /* These following macros are copied from BSD sys/queue.h
> Copyright (c) 1991, 1993, The Regents of the University of
> California.
> All rights reserved.
> */
>
> #define TAILQ_EMPTY(head) ((head)->tqh_first == NULL)
>
> I checked the BSD code and the macros has similar names, but
> implementation is different.
>
> As the names as such are not copyrightable and we don't strictly
> need the
> above comment but I agree that it's good to give credits where credits
> is due, so lets keep them.
>
> I also checked that the README file contains the Copyright text
> required by the BSD code, so we are in the clear regarding this.
>
> Arjen, ok to push your fix to the 5.1-release tree.
>
> Regards,
> Monty

--
Arjen Lentz, Exec.Director @ Open Query (http://openquery.com)
Exceptional Services for MySQL at a fixed budget.

Follow our blog at http://openquery.com/blog/
OurDelta: packages for MySQL and MariaDB @ http://ourdelta.org

[Toby Thain (qu1j0t3)]

On 3-Nov-09, at 6:52 PM, Arjen Lentz wrote:

> Hi Monty
>
> We should also have -Wimplicit, as it would have caught the problem
> during the compile phase rather than chucking a link (missing symbol)
> error.
> I'd love to see MySQL compiled cleanly with -pedantic.

Short of that, you can crank up the warning levels with -Wall, -Wextra ?

--Toby

[Kristian Nielsen (knielsen)]

This has been pushed into lp:~maria-captains/maria/5.1-release.

Thanks!