problems with savepoints and tokudb with 5.5
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MariaDB |
Fix Committed
|
High
|
Sergei Golubchik |
Bug Description
We observed a problem with savepoints in Mariadb 5.5.25. The problem at the SQL layer is that a "rollback to savepoint" statement would get an error after the savepoint was created. The problem was caused by the savepoint name in the savepoint stack getting overwritten by the handlerton savepoint_set method.
We believe that the handler savepoint_offset initialization is WRONG. The ha_initialize_
Suppose that savepoint_
After the first savepoint init code is executed at line 504, savepoint_
After the second savepoint int code is executed at line 530, savepoint_
So, the handlerton's savepoint is outside of the memory allocated for the savepoint state.
Our fix is here: lp:~prohaska7/maria/5.5-savepoint-offset-fix
Related branches
Changed in maria: | |
assignee: | nobody → Kristian Nielsen (knielsen) |
milestone: | none → 5.5 |
assignee: | Kristian Nielsen (knielsen) → Sergei (sergii) |
Changed in maria: | |
status: | Confirmed → Fix Committed |
Thanks! It must be a result of a merge - the initialization code was moved down in mysql-5.5, and when merging it into mariadb bzr decided to keep both copies for some reason. Sorry for this!