[proxy] - Regression failures on list queues

Bug #1234481 reported by Malini Kamalambal
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Critical
Zhihao Yuan

Bug Description

Outcome
=======

The following functional tests are failing after the proxy changes.
tests.functional.wsgi.v1.test_queues.TestQueueMisc.test_list_queue_invalid_limit_-1 ... FAIL
tests.functional.wsgi.v1.test_queues.TestQueueMisc.test_list_queue_invalid_limit_0 ... FAIL
tests.functional.wsgi.v1.test_queues.TestQueueMisc.test_list_queue_invalid_limit_30 ... FAIL
tests.functional.wsgi.v1.test_queues.TestQueueMisc.test_list_queues_detailed … FAIL

#1, 2 & 3 (List Queues with invalid value for limit ) are returning 200s instead of http 400.
#4 (List Queues with detailed=True) is returning http 500

More details here : http://paste.openstack.org/show/47876/

Summary
=======

Scenarios
---------

1. Listing queues with an invalid limit
2. Listing queues with detailed=True

Errors
------

For scenario 1, the invalid limit is ignored and results are returned.
For scenario 2, the proxy returns a 500 level error.

Allele Dev (alleledev)
Changed in marconi:
status: New → Confirmed
importance: Undecided → Critical
Allele Dev (alleledev)
description: updated
Revision history for this message
Zhihao Yuan (zyuan) wrote :

Found one possible reason.

Changed in marconi:
assignee: nobody → Zhihao Yuan (zyuan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to marconi (master)

Fix proposed to branch: master
Review: https://review.openstack.org/49783

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to marconi (master)

Reviewed: https://review.openstack.org/49783
Committed: http://github.com/openstack/marconi/commit/943213fadb2a41a85ee42dde6ebc52142eb9dd57
Submitter: Jenkins
Branch: master

commit 943213fadb2a41a85ee42dde6ebc52142eb9dd57
Author: Zhihao Yuan <email address hidden>
Date: Fri Oct 4 12:08:59 2013 -0400

    fix: listing queue fails when detailed=True

    Change-Id: Ibda6bf0ee500b1e21893c1433bf3b839af1cef22
    Partially-Closes-Bug: 1234481

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/50342
Committed: http://github.com/openstack/marconi/commit/39d0d2f52299fd93ba6a00ca2f113a24ec370aba
Submitter: Jenkins
Branch: master

commit 39d0d2f52299fd93ba6a00ca2f113a24ec370aba
Author: Alejandro Cabrera <email address hidden>
Date: Tue Oct 8 09:08:27 2013 -0400

    fix: validate queue listing limits in proxy

    Adds the appropriate unit test to show that this works and keeps
    working for the forseeable future.

    Change-Id: I25d3ba3f9b1e3a51d8ba86171cd7329585c3e080
    Closes-Bug: 1234481

Changed in marconi:
status: Confirmed → Fix Committed
Thierry Carrez (ttx)
Changed in marconi:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in marconi:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.