perf: Functions defined inline

Bug #1222932 reported by Kurt Griffiths
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
zaqar
Invalid
Low
Annapoornima Koppad

Bug Description

In some cases, functions are defined inside another function body unnecessarily. Constructing the inner function for each call substantially slows down the call to the outer function.

Kurt Griffiths (kgriffs)
Changed in marconi:
importance: Medium → Low
Changed in marconi:
assignee: nobody → Fei Long Wang (flwang)
Revision history for this message
Kurt Griffiths (kgriffs) wrote :

Let's move this to Juno

no longer affects: marconi/icehouse
Changed in marconi:
milestone: icehouse-3 → none
Changed in marconi:
milestone: none → icehouse-rc1
Kurt Griffiths (kgriffs)
Changed in marconi:
milestone: icehouse-rc1 → none
Revision history for this message
Flavio Percoco (flaper87) wrote :

@Seif, are you actively working on this bug?

@kgriffs would it be possible to get a list of nested functions you think we should get rid of?

Changed in zaqar:
milestone: none → kilo-1
Changed in zaqar:
milestone: kilo-1 → kilo-2
assignee: Seif Lotfy (seif) → nobody
milestone: kilo-2 → none
tags: added: low-hanging-fruit
Changed in zaqar:
assignee: nobody → Akanksha Srivastava (akanksha-dlf)
Changed in zaqar:
assignee: Akanksha Srivastava (akanksha-dlf) → Tahio Avila (thavila87)
Changed in zaqar:
assignee: Tahio Avila (thavila87) → Annapoornima Koppad (annakoppad)
Revision history for this message
Chris Suttles (killface007) wrote :

I don't see this when looking through the code base; is this bug still valid?

Revision history for this message
wangxiyuan (wangxiyuan) wrote :

Set to Invalid now, please update it if we still need this.

Changed in zaqar:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.