Documentation of _congfiguredObserver has a typo
Bug #1231698 reported by
Glenn Ramsey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAPClient |
Fix Released
|
Low
|
Unassigned |
Bug Description
The documentation says:
A Step Should
Implement the configure method to configure the step. This is typically in the form of a dialog. When implementing this function the class method self._configure
self._configure
Apparently it also needs to set self._configured to True. Since _configured is a private variable it would be better to provide a public method to do this. I suggest
void setConfigured(bool) and bool getConfigured() (psuedocode, not python)
Related branches
lp:mapclient/bugfixes
- Hugh Sorby: Approve
-
Diff: 549 lines (+169/-67)12 files modifiedplugins/skeletonstep/__init__.py (+3/-3)
plugins/skeletonstep/skeletonstep/step.py (+8/-8)
src/core/threadcommandmanager.py (+36/-37)
src/widgets/aboutdialog.py (+7/-2)
src/widgets/mainwindow.py (+15/-1)
src/widgets/qt/aboutdialog.ui (+12/-3)
src/widgets/ui_aboutdialog.py (+7/-7)
src/widgets/workflowgraphicsitems.py (+6/-2)
src/widgets/workflowgraphicsscene.py (+1/-1)
src/widgets/workflowwidget.py (+22/-2)
tests/widgets_tests/utils.py (+46/-0)
tests/widgets_tests/widgetstests.py (+6/-1)
description: | updated |
description: | updated |
summary: |
- Documenation of _congfiguredObserver has a typo + Documentation of _congfiguredObserver has a typo |
Changed in mapclient: | |
milestone: | none → 0.9.1 |
Changed in mapclient: | |
status: | New → Fix Committed |
importance: | Undecided → Low |
Changed in mapclient: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.