Always enable the execute button
Bug #1231186 reported by
Glenn Ramsey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAPClient |
Fix Committed
|
Medium
|
Unassigned | ||
Bug Description
It is not obvious that a workflow must be saved before the execute button is enabled.
Would it be possible to make this work the other way around? That is have the execute button always enabled and then provide feedback to the user if there is some reason that the workflow can not be executed. Also by doing that way it could be saved automatically before executing.
Alternatively a tooltip could be added to the execute button when it is disabled that tells the user to save, but that would not be as good as the above solution.
Related branches
lp:mapclient/bugfixes
- Hugh Sorby: Approve
-
Diff: 549 lines (+169/-67)12 files modifiedplugins/skeletonstep/__init__.py (+3/-3)
plugins/skeletonstep/skeletonstep/step.py (+8/-8)
src/core/threadcommandmanager.py (+36/-37)
src/widgets/aboutdialog.py (+7/-2)
src/widgets/mainwindow.py (+15/-1)
src/widgets/qt/aboutdialog.ui (+12/-3)
src/widgets/ui_aboutdialog.py (+7/-7)
src/widgets/workflowgraphicsitems.py (+6/-2)
src/widgets/workflowgraphicsscene.py (+1/-1)
src/widgets/workflowwidget.py (+22/-2)
tests/widgets_tests/utils.py (+46/-0)
tests/widgets_tests/widgetstests.py (+6/-1)
Revision history for this message
| Hugh Sorby (h-sorby) wrote | #1 |
| Changed in mapclient: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in mapclient: | |
| status: | Confirmed → Fix Committed |
To post a comment you must log in.
I think you are right that it is not obvious that the workflow must be saved before the execute button is enabled. It also goes further in that every connected step must be successfully configured before the workflow can be executed.
I will investigate the difficulties in having the execute button always enabled and then providing feedback about what is wrong if the requirements for execution are not currently met. I think in the case of the workflow not being saved an option would have to be made settable where the user could set the option to always save before execution.