CertificateOptions API change

Bug #1208308 reported by Tristan Seligmann on 2013-08-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Divmod Mantissa
Medium
Tristan Seligmann

Bug Description

xmantissa.port expects a privateKeyFileName attribute on the SSL context factory, but CertificateOptions does not have this, resulting in a number of test failures such as:

[FAIL]
Traceback (most recent call last):
  File "/home/mithrandi/code/Divmod/trunk/Mantissa/xmantissa/test/test_port.py", line 987, in test_createSSLPortInconsistentCertificateAndKeyFiles
    "--factory-identifier", str(factory.storeID)])
  File "/home/mithrandi/code/Divmod/trunk/Mantissa/xmantissa/test/test_port.py", line 484, in assertFailStatus
    exc = self.assertRaises(SystemExit, options.parseOptions, arguments)
  File "/home/mithrandi/code/Twisted/trunk/twisted/trial/_synctest.py", line 335, in assertRaises
    failure.Failure().getTraceback()))
twisted.trial.unittest.FailTest: <type 'exceptions.AttributeError'> raised instead of SystemExit:
 Traceback (most recent call last):
  File "/home/mithrandi/code/Twisted/trunk/twisted/internet/defer.py", line 139, in maybeDeferred
    result = f(*args, **kw)
  File "/home/mithrandi/code/Twisted/trunk/twisted/internet/utils.py", line 199, in runWithWarningsSuppressed
    result = f(*a, **kw)
  File "/home/mithrandi/code/Divmod/trunk/Mantissa/xmantissa/test/test_port.py", line 987, in test_createSSLPortInconsistentCertificateAndKeyFiles
    "--factory-identifier", str(factory.storeID)])
  File "/home/mithrandi/code/Divmod/trunk/Mantissa/xmantissa/test/test_port.py", line 484, in assertFailStatus
    exc = self.assertRaises(SystemExit, options.parseOptions, arguments)
--- <exception caught here> ---
  File "/home/mithrandi/code/Twisted/trunk/twisted/trial/_synctest.py", line 328, in assertRaises
    result = f(*args, **kwargs)
  File "/home/mithrandi/code/Twisted/trunk/twisted/python/usage.py", line 266, in parseOptions
    self.subOptions.parseOptions(rest)
  File "/home/mithrandi/code/Twisted/trunk/twisted/python/usage.py", line 276, in parseOptions
    self.postOptions()
  File "/home/mithrandi/code/Divmod/trunk/Mantissa/xmantissa/port.py", line 472, in postOptions
    port = method(store, *args, **kwargs)
  File "/home/mithrandi/code/Divmod/trunk/Mantissa/xmantissa/port.py", line 493, in create_SSL
    key = context.privateKeyFileName
exceptions.AttributeError: 'OpenSSLCertificateOptions' object has no attribute 'privateKeyFileName'

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers