OpenStack Shared File Systems Service (Manila)

Add missing db_retry for update methods

Bug #2084529 reported by kiran pawar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
kiran pawar
OpenStack Shared File Systems Service (Manila) epoxy-2

Bug Description

Filed a bug to add missing db_retry decorator.
decorate all missing *_update methods with db_retry on deadlock e.g. share_resources_host_update

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/932397

Changed in manila:
status: New → In Progress
Goutham Pacha Ravi (gouthamr)
Changed in manila:
importance: Undecided → Low
assignee: nobody → kiran pawar (kpdev)
milestone: none → epoxy-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/932397
Committed: https://opendev.org/openstack/manila/commit/b64e5a35e1067976de3c92372476582b4d99a3ac
Submitter: "Zuul (22348)"
Branch: master

commit b64e5a35e1067976de3c92372476582b4d99a3ac
Author: Kiran Pawar <email address hidden>
Date: Tue Oct 15 10:01:21 2024 +0000

    decorate all missing *_update methods with db_retry on deadlock

    Share instance records and their relations were missing db_retry and
    so added the db_retry decorator.

    Co-Authored-By: Maurice Escher <email address hidden>
    Closes-bug: #2084529
    Change-Id: Iac0bee438365ab0902859df74647f1502c619270

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/2024.2)

Fix proposed to branch: stable/2024.2
Review: https://review.opendev.org/c/openstack/manila/+/935849

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/2024.1)

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/manila/+/935853

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/2024.2)

Reviewed: https://review.opendev.org/c/openstack/manila/+/935849
Committed: https://opendev.org/openstack/manila/commit/052e324e26b6ebdc4b8e011df9f41b43f1cea09b
Submitter: "Zuul (22348)"
Branch: stable/2024.2

commit 052e324e26b6ebdc4b8e011df9f41b43f1cea09b
Author: Kiran Pawar <email address hidden>
Date: Tue Oct 15 10:01:21 2024 +0000

    decorate all missing *_update methods with db_retry on deadlock

    Share instance records and their relations were missing db_retry and
    so added the db_retry decorator.

    Co-Authored-By: Maurice Escher <email address hidden>
    Closes-bug: #2084529
    Change-Id: Iac0bee438365ab0902859df74647f1502c619270
    (cherry picked from commit b64e5a35e1067976de3c92372476582b4d99a3ac)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/2024.1)

Reviewed: https://review.opendev.org/c/openstack/manila/+/935853
Committed: https://opendev.org/openstack/manila/commit/1d545d3f195ae1fb98e4b7a572c1d4a50b7ea4a0
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit 1d545d3f195ae1fb98e4b7a572c1d4a50b7ea4a0
Author: Kiran Pawar <email address hidden>
Date: Tue Oct 15 10:01:21 2024 +0000

    decorate all missing *_update methods with db_retry on deadlock

    Share instance records and their relations were missing db_retry and
    so added the db_retry decorator.

    Co-Authored-By: Maurice Escher <email address hidden>
    Closes-bug: #2084529
    Change-Id: Iac0bee438365ab0902859df74647f1502c619270
    (cherry picked from commit b64e5a35e1067976de3c92372476582b4d99a3ac)
    (cherry picked from commit 052e324e26b6ebdc4b8e011df9f41b43f1cea09b)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 20.0.0.0rc1

This issue was fixed in the openstack/manila 20.0.0.0rc1 Epoxy release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 18.3.0

This issue was fixed in the openstack/manila 18.3.0 Caracal release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 19.1.0

This issue was fixed in the openstack/manila 19.1.0 Dalmatian release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.