Dell PowerFlex: The default value for the Dell NAS backend port does not function properly if the configuration key is not explicitly defined.

Bug #2066840 reported by Nilesh Thathagar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
In Progress
Low
dell openstack engineering

Bug Description

Description
===========
The dell_nas_backend_port has a default value of 443. However, if this parameter is not defined in the configuration, it should default to this value, but instead, it results in errors.

Steps to reproduce
==================
1. Remove the configuration parameter key dell_nas_backend_port from manila.conf file

Expected result
===============
The manila share service should start with the default port value which is 443.

Actual result
=============
Getting errors
May 17 05:29:30 host001010 manila-share[101219]: ERROR manila.share.manager self.plugin.connect(self, context)
May 17 05:29:30 host001010 manila-share[101219]: ERROR manila.share.manager File "/opt/stack/manila/manila/share/drivers/dell_emc/plugins/powerflex/connection.py", line 103, in connect
May 17 05:29:30 host001010 manila-share[101219]: ERROR manila.share.manager self.rest_port = (int(get_config_value("dell_nas_backend_port")) or
May 17 05:29:30 host001010 manila-share[101219]: ERROR manila.share.manager TypeError: int() argument must be a string, a bytes-like object or a real number, not 'NoneType'

Changed in manila:
assignee: nobody → dell openstack engineering (dell-openstack)
summary: - Dell PowerFlex: Dell NAS Backend Port Default Value Not Working If We
- Does Not Define The Config Key
+ Dell PowerFlex: The default value for the Dell NAS backend port does not
+ function properly if the configuration key is not explicitly defined.
Vida Haririan (vhariria)
Changed in manila:
status: New → Triaged
Vida Haririan (vhariria)
Changed in manila:
importance: Undecided → Low
tags: added: low-hanging-fruit
Revision history for this message
Vida Haririan (vhariria) wrote :
Revision history for this message
Nilesh Thathagar (nileshthathagar) wrote :

This issue is easily reproducible. I will implement a fix as soon as possible.

Changed in manila:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/921843

Changed in manila:
milestone: none → dalmatian-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/921843
Committed: https://opendev.org/openstack/manila/commit/d7f7b6312a3529f6f23cc541114594308f85e1af
Submitter: "Zuul (22348)"
Branch: master

commit d7f7b6312a3529f6f23cc541114594308f85e1af
Author: Nilesh Thathagar <email address hidden>
Date: Wed Jun 12 10:01:25 2024 +0000

    Dell PowerFlex: Set default value for port config

    Added default port value for the Dell PowerFlex
    NAS backend

    Closes-Bug: #2066840
    Change-Id: Ifda8c0b179763fe0884ef3845b6836be861ca6a8

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/2024.1)

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/manila/+/922191

Vida Haririan (vhariria)
Changed in manila:
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/2024.1)

Reviewed: https://review.opendev.org/c/openstack/manila/+/922191
Committed: https://opendev.org/openstack/manila/commit/f0c33dec536708c940f2010d11dd8c778c28d2e7
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit f0c33dec536708c940f2010d11dd8c778c28d2e7
Author: Nilesh Thathagar <email address hidden>
Date: Wed Jun 12 10:01:25 2024 +0000

    Dell PowerFlex: Set default value for port config

    Added default port value for the Dell PowerFlex
    NAS backend

    Closes-Bug: #2066840
    Change-Id: Ifda8c0b179763fe0884ef3845b6836be861ca6a8
    (cherry picked from commit d7f7b6312a3529f6f23cc541114594308f85e1af)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/manila/+/922560

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.