[netapp] last-transfer-size check in update_replica_state

[chuan137]

Hi,

We have introduced last-transfer-* checks in [1] to NetApp driver. The last-transfer-size check has not worked very well in production. Relicas with frequent data changes always stay in 'out-of-sync' for its 'replica_state'. I think it would make sense only keep last-transfer-error check, because the main purpose of the checks is to verify if the child replica is snapmirrored with the source.

We could remove the check from code base, or set a very high default value to `netapp_snapmirror_last_transfer_size_limit`. The current default is 1MB, which is probably a pitfall for admins to setup manila replica feature using NetApp driver.

Best regards,
Chuan

[1]: https://review.opendev.org/c/openstack/manila/+/856756

[Vida Haririan (vhariria)]

See additional triage information at https://meetings.opendev.org/meetings/manila/2024/manila.2024-05-23-15.00.log.txt