extending a share that was created from snapshot uses wrong limit

[Maurice Escher]

Hi,

I want to extend a share, that was originally created from a snapshot (i.e. it has a snapshot_id set).

I expect the capacity filter to honor my reserved_share_extend_percentage setting (which has been implemented to solve https://bugs.launchpad.net/manila/+bug/1961087), but instead it uses the reserved_snapshot_percentage limit.

I think this is a bug, reserved_snapshot_percentage should only be taken on share create from snapshot scheduling decisions, not on extend decisions.

What do you think?

BR,
Maurice

[Vida Haririan (vhariria)]

See additional discussions at https://meetings.opendev.org/meetings/manila/2024/manila.2024-01-25-15.00.log.html

[Maurice Escher (maurice-escher)]

> carloss: if we don't have volunteers, we can ask carthaca if they have someone in mind to work on it

Yes, a colleague of mine will start working on this.
In the meantime I'll assign it to myself.