OpenStack Shared File Systems Service (Manila)

retry on connection error to neutron

Bug #2049507 reported by kiran pawar
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
kiran pawar

Bug Description

Retry https://paste.opendev.org/show/bCtEYsFr0oTfhY9b2r34/

so that a connection error to neutron (maybe due to kubernetes maintenance) does not immediately lead to share create failure. May be retry for 5 times with keystone connection failure to avoid duplicate port create in neutron. If duplicate ports are created, they become orphan after share deletion. So Manila should give a try to make sure duplicate ports are not created.

kiran pawar (kpdev)
Changed in manila:
assignee: nobody → kiran pawar (kpdev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/905695

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/905695
Committed: https://opendev.org/openstack/manila/commit/09c51d297877022ceb94b01903ad4e60fca19955
Submitter: "Zuul (22348)"
Branch: master

commit 09c51d297877022ceb94b01903ad4e60fca19955
Author: Kiran Pawar <email address hidden>
Date: Tue Jan 16 14:07:41 2024 +0000

    Retry on connection error to neutron

    In case of keystoneauth1 ConnectError, manila will retry the neutron
    API call. For create_port(), it will make sure no duplicate ports
    are created.

    Closes-bug: #2049507
    Change-Id: I12fece58671e9fb3705e22090187c42d9c3a74d9

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/manila/+/908697

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/manila/+/908769

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/manila/+/908697
Committed: https://opendev.org/openstack/manila/commit/a9cea65b45f0c0bf148b6ac9db0a8141c74fa2a6
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit a9cea65b45f0c0bf148b6ac9db0a8141c74fa2a6
Author: Kiran Pawar <email address hidden>
Date: Tue Jan 16 14:07:41 2024 +0000

    Retry on connection error to neutron

    In case of keystoneauth1 ConnectError, manila will retry the neutron
    API call. For create_port(), it will make sure no duplicate ports
    are created.

    Closes-bug: #2049507
    Change-Id: I12fece58671e9fb3705e22090187c42d9c3a74d9
    (cherry picked from commit 09c51d297877022ceb94b01903ad4e60fca19955)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/manila/+/908769
Committed: https://opendev.org/openstack/manila/commit/7dbba77f8559532f46db3be24f698dbd81846279
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 7dbba77f8559532f46db3be24f698dbd81846279
Author: Kiran Pawar <email address hidden>
Date: Tue Jan 16 14:07:41 2024 +0000

    Retry on connection error to neutron

    In case of keystoneauth1 ConnectError, manila will retry the neutron
    API call. For create_port(), it will make sure no duplicate ports
    are created.

    Closes-bug: #2049507
    Change-Id: I12fece58671e9fb3705e22090187c42d9c3a74d9
    (cherry picked from commit 09c51d297877022ceb94b01903ad4e60fca19955)
    (cherry picked from commit a9cea65b45f0c0bf148b6ac9db0a8141c74fa2a6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/manila/+/908939

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 18.0.0.0rc1

This issue was fixed in the openstack/manila 18.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/manila/+/908939
Committed: https://opendev.org/openstack/manila/commit/9b2916254cded2266a2594be1748fa4d88de5e9b
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 9b2916254cded2266a2594be1748fa4d88de5e9b
Author: Kiran Pawar <email address hidden>
Date: Tue Jan 16 14:07:41 2024 +0000

    Retry on connection error to neutron

    In case of keystoneauth1 ConnectError, manila will retry the neutron
    API call. For create_port(), it will make sure no duplicate ports
    are created.

    Closes-bug: #2049507
    Change-Id: I12fece58671e9fb3705e22090187c42d9c3a74d9
    (cherry picked from commit 09c51d297877022ceb94b01903ad4e60fca19955)
    (cherry picked from commit a9cea65b45f0c0bf148b6ac9db0a8141c74fa2a6)
    (cherry picked from commit 7dbba77f8559532f46db3be24f698dbd81846279)

tags: added: in-stable-zed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.