delete share should not fail on removing affinity hints

[Maurice Escher]

Hi,

what happened?
share A that referenced share B in an anti-affinity rule should be deleted.
That failed with below error.

Reason: share B is no longer existing.

Proposed fix: _delete_scheduler_hints() should catch `NotFound` in addition to already catching `ShareMetadataNotFound``

error from manila shell:
https://paste.opendev.org/show/bu3XA0fMroRPq3AnIuK7/

That was a bit tricky to find out, because the NotFound error bubbled up to the delete request and was very confusing (we took long until we figured out that this is not a permission issue)

BR,
Maurice

[Vida Haririan (vhariria)]

Hi, Thank you for reporting this issue.
Please add reproduce steps to the bug

[Vida Haririan (vhariria)]

See additional comments at https://meetings.opendev.org/meetings/manila/2023/manila.2023-09-14-15.00.log.html

[kizdorothy (kizdorothy)]

Hello, I would like to work on this issue. Hopefully, i can reproduce it.

[Maurice Escher (maurice-escher)]

Hi, I assigned this to myself because a colleague of mine (a first time contributor) started working on this - downstream the fix is already present (https://github.com/sapcc/manila/pull/144), we just need to bring it up.
Reproducing was not easy, it appeared to be an edge case

[kizdorothy (kizdorothy)]

Thanks for letting me know, let see what i can work on.