Fix share/snapshot list API with count param

[kiran pawar]

Manila share list and share snapshot list APIs, return list of shares and snapshots respectively. In addition these API support param '--count' which return count of shares and snapshots in respective API. However it is observed that these APIs return incorrect count as they return share instances and share snapshot instances count while list returned contains only shares and share snapshots respectively.

Fix this by making sure count return correct value of shares and not share instances. Similar is applicable for share snapshots.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/893345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/893345
Committed: https://opendev.org/openstack/manila/commit/9e835496dc2e87d1137749e6420852e41735bf4f
Submitter: "Zuul (22348)"
Branch: master

commit 9e835496dc2e87d1137749e6420852e41735bf4f
Author: Kiran Pawar <email address hidden>
Date: Thu Aug 31 08:33:54 2023 +0000

    Fix count in the response of shares/snapshots list API

    Share/Snapshot list API returns count of shares/snapshotsi along-with
    list of resource objects. The list returned by API contains correct
    entries of shares/snapshots but it returns the wrong count as it
    ShareInstances/SnapshotInstances. So filter queries by unique
    share_id/snapshot_id.

    Closes-bug: #2033604
    Change-Id: I13c415767b0d126563f9553df415de564b3901d6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/manila/+/895919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/895919
Committed: https://opendev.org/openstack/manila/commit/6b61b065b0ce1620bed228b6e4d34cb8773761b7
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 6b61b065b0ce1620bed228b6e4d34cb8773761b7
Author: Kiran Pawar <email address hidden>
Date: Thu Aug 31 08:33:54 2023 +0000

    Fix count in the response of shares/snapshots list API

    Share/Snapshot list API returns count of shares/snapshotsi along-with
    list of resource objects. The list returned by API contains correct
    entries of shares/snapshots but it returns the wrong count as it
    ShareInstances/SnapshotInstances. So filter queries by unique
    share_id/snapshot_id.

    Closes-bug: #2033604
    Change-Id: I13c415767b0d126563f9553df415de564b3901d6
    (cherry picked from commit 9e835496dc2e87d1137749e6420852e41735bf4f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 17.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 18.0.0.0rc1 release candidate.