Dangling security association record in DB after network delete

[Vadym Markov]

Affected version:

Reproduced on Devstack/Yoga, but any recent environment with Manila should be affected

Steps to reproduce:
1. Create security service:
manila security-service-create --name sec_serv_1 ldap
2. Create share network:
manila share-network-create --name share_net_1
3. Associate them:
manila share-network-security-service-add share_net_1 sec_serv_1
4. Delete network:
manila share-network-delete share_net_1

After it, we have a non-deleted record in share_network_security_service_association table relating to soft-deleted network. It has foreign key constraints with table share_networks. These constraints prevent purge job to cleanup soft-deleted networks. Same actions, but deleting security service works correctly - delete of security service propagates to association delete

[Vida Haririan (vhariria)]

See additional related discussions at https://meetings.opendev.org/meetings/manila/2023/manila.2023-08-03-15.00.log.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/891778

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/891778
Committed: https://opendev.org/openstack/manila/commit/42e66d9f38b63183e92af939fa7f0a94d97a482f
Submitter: "Zuul (22348)"
Branch: master

commit 42e66d9f38b63183e92af939fa7f0a94d97a482f
Author: BubaVV <email address hidden>
Date: Tue Jul 11 21:30:48 2023 +0300

    Fix share network delete procedure

    Currently, delete of share network leaves security service associations
    behind it. DB purge job can't process them because they are constrained
    to soft-deleted networks. Proposed patch fixes both formation of
    orphaned associations and seamless purging of them.

    Closes-Bug: #2029366
    Change-Id: I9593dd6e89b2d290d3919c92d209132e1cec84f0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/manila/+/896767

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/896767
Committed: https://opendev.org/openstack/manila/commit/4a006f8f931f1cc4422f0c788ede0e69e11cfbb1
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 4a006f8f931f1cc4422f0c788ede0e69e11cfbb1
Author: BubaVV <email address hidden>
Date: Tue Jul 11 21:30:48 2023 +0300

    Fix share network delete procedure

    Currently, delete of share network leaves security service associations
    behind it. DB purge job can't process them because they are constrained
    to soft-deleted networks. Proposed patch fixes both formation of
    orphaned associations and seamless purging of them.

    Closes-Bug: #2029366
    Change-Id: I9593dd6e89b2d290d3919c92d209132e1cec84f0
    (cherry picked from commit 42e66d9f38b63183e92af939fa7f0a94d97a482f)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/manila/+/897449

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 17.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 18.0.0.0rc1 release candidate.