OpenStack Shared File Systems Service (Manila)

share server share network not found error message misleading

Bug #2025649 reported by Maurice Escher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Felipe Rodrigues
OpenStack Shared File Systems Service (Manila) bobcat-3

Bug Description

Hi,

on share server show, if the share network is not existing I get an error.

But the ID shown is the ID of the share network, the error message makes the impression it would be the ID of the share server (the one I provided already).

Proposed fix
""Share server 41296d9b-d0e1-4476-b652-408861c80c9e could not be found. Its associated share network does not exist.""

could be changed to
""Share server could not be found. Its associated share network 41296d9b-d0e1-4476-b652-408861c80c9e does not exist.""

in https://opendev.org/openstack/manila/src/commit/68127fe444412c2acd28eeca6984fc6f2c7bf241/manila/api/v1/share_servers.py#L97-L99

BR,
Maurice

Maurice Escher (maurice-escher)
tags: added: low-hanging-fruit
Vida Haririan (vhariria)
Changed in manila:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Vida Haririan (vhariria) wrote :

See additional related discussions at https://meetings.opendev.org/meetings/manila/2023/manila.2023-07-13-15.00.log.html

Felipe Rodrigues (felipefutty)
Changed in manila:
assignee: nobody → Felipe Rodrigues (felipefutty)
Goutham Pacha Ravi (gouthamr)
Changed in manila:
milestone: none → bobcat-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/manila/+/892583

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/manila/+/892584

Vida Haririan (vhariria)
Changed in manila:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 17.0.0.0rc1

This issue was fixed in the openstack/manila 17.0.0.0rc1 release candidate.

Carlos Eduardo (silvacarlose)
Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/manila/+/892583
Committed: https://opendev.org/openstack/manila/commit/bc2e30390468e066d328680a87dab8e06a0f524d
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit bc2e30390468e066d328680a87dab8e06a0f524d
Author: Felipe Rodrigues <email address hidden>
Date: Mon Jul 31 09:24:59 2023 -0300

    Fix error message from share server API

    Fixing share server api error message when share network
    does not exist.

    Closes-bug: #2025649
    Change-Id: I19a2f7dbb2375b2d3a281efa673da986f29aa9d6
    (cherry picked from commit 456b90898f6a7b1a4bc29170deaf9d6c40c138f7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 16.1.0

This issue was fixed in the openstack/manila 16.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila/+/898444

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/manila/+/892584
Committed: https://opendev.org/openstack/manila/commit/7adab824cf779b4781dd119fbf5999f2adc370c4
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 7adab824cf779b4781dd119fbf5999f2adc370c4
Author: Felipe Rodrigues <email address hidden>
Date: Mon Jul 31 09:24:59 2023 -0300

    Fix error message from share server API

    Fixing share server api error message when share network
    does not exist.

    Closes-bug: #2025649
    Change-Id: I19a2f7dbb2375b2d3a281efa673da986f29aa9d6
    (cherry picked from commit 456b90898f6a7b1a4bc29170deaf9d6c40c138f7)
    (cherry picked from commit bc2e30390468e066d328680a87dab8e06a0f524d)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 15.3.0

This issue was fixed in the openstack/manila 15.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/manila/+/898444
Committed: https://opendev.org/openstack/manila/commit/4833319ca59580a7af0231aa1393cf772c7774f8
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 4833319ca59580a7af0231aa1393cf772c7774f8
Author: Felipe Rodrigues <email address hidden>
Date: Mon Jul 31 09:24:59 2023 -0300

    Fix error message from share server API

    Fixing share server api error message when share network
    does not exist.

    Closes-bug: #2025649
    Change-Id: I19a2f7dbb2375b2d3a281efa673da986f29aa9d6
    (cherry picked from commit 456b90898f6a7b1a4bc29170deaf9d6c40c138f7)
    (cherry picked from commit bc2e30390468e066d328680a87dab8e06a0f524d)
    (cherry picked from commit 7adab824cf779b4781dd119fbf5999f2adc370c4)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/manila/+/905355

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/manila/+/905334

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/manila/+/905355
Committed: https://opendev.org/openstack/manila/commit/1751df33908bea6be354b1c79507f7072143a2ae
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 1751df33908bea6be354b1c79507f7072143a2ae
Author: Felipe Rodrigues <email address hidden>
Date: Mon Jul 31 09:24:59 2023 -0300

    Fix error message from share server API

    Fixing share server api error message when share network
    does not exist.

    Closes-bug: #2025649
    Change-Id: I19a2f7dbb2375b2d3a281efa673da986f29aa9d6
    (cherry picked from commit 456b90898f6a7b1a4bc29170deaf9d6c40c138f7)
    (cherry picked from commit bc2e30390468e066d328680a87dab8e06a0f524d)
    (cherry picked from commit 7adab824cf779b4781dd119fbf5999f2adc370c4)
    (cherry picked from commit 4833319ca59580a7af0231aa1393cf772c7774f8)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/manila/+/905334
Committed: https://opendev.org/openstack/manila/commit/20a3055c237d1651fd6812f0a767048dc131d717
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 20a3055c237d1651fd6812f0a767048dc131d717
Author: Felipe Rodrigues <email address hidden>
Date: Mon Jul 31 09:24:59 2023 -0300

    Fix error message from share server API

    Fixing share server api error message when share network
    does not exist.

    Closes-bug: #2025649
    Change-Id: I19a2f7dbb2375b2d3a281efa673da986f29aa9d6
    (cherry picked from commit 456b90898f6a7b1a4bc29170deaf9d6c40c138f7)
    (cherry picked from commit bc2e30390468e066d328680a87dab8e06a0f524d)
    (cherry picked from commit 7adab824cf779b4781dd119fbf5999f2adc370c4)
    (cherry picked from commit 4833319ca59580a7af0231aa1393cf772c7774f8)
    (cherry picked from commit 1751df33908bea6be354b1c79507f7072143a2ae)
    (cherry picked from commit 1d6d4190b97967d22b8ac069bee946ecc3b6eb5c)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 14.2.0

This issue was fixed in the openstack/manila 14.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila wallaby-eom

This issue was fixed in the openstack/manila wallaby-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila xena-eom

This issue was fixed in the openstack/manila xena-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.