share export location not updated with netapp driver

[Sylvan Le Deunff]

Description
===========
When adding a subnet to a share network that is used by a share, the list of export path of this share is not updated. This bug is specific to NetApp multi SVM driver.

Steps to reproduce
==================

A chronological list of steps which will help reproduce the issue you hit:
* Configure manila to use NetApp drv_multi_svm share driver with option driver_handle_share_server=true
* Create a share network (this automatically create a default share network subnet)
* Create a share using this share network
* Create a share network subnet check
* Add a second subnet to this share network

Expected result
===============
The list of share's export paths should now contains 2 export paths, 1 in each subnet.

Actual result
=============
Export path list is not updated when the second subnet is created.

This is due to the following check: https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py#L2306

[Carlos Eduardo (silvacarlose)]

Hello, Sylvan! Thank you for the bug report. I see you have assigned yourself to this bug. Are you working on a fix? If not, we can ask the NetApp driver maintainers to take a look at this bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/882130

[Sylvan Le Deunff (sylvanld)]

Hello, Carlos! Yes I just managed to submit the fix. It consists in removing the condition that seems needless.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/882130
Committed: https://opendev.org/openstack/manila/commit/07ce64462c63c5253226a733f5686e78eb7223a1
Submitter: "Zuul (22348)"
Branch: master

commit 07ce64462c63c5253226a733f5686e78eb7223a1
Author: Sylvan Le Deunff <email address hidden>
Date: Wed May 3 10:49:12 2023 +0200

    Fix export locations update when subnet is added

    Export locations of active share replicas was updated
    but not those of the share itself.

    Closes-Bug: #2017501
    Change-Id: I33204657401f3eadd490fc50fedaef899dcff297

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/manila/+/929093

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/manila/+/929151

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/manila/+/929152

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/929093
Committed: https://opendev.org/openstack/manila/commit/5b77e4756104554fe024d086241e81e46d71d1ed
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit 5b77e4756104554fe024d086241e81e46d71d1ed
Author: Sylvan Le Deunff <email address hidden>
Date: Wed May 3 10:49:12 2023 +0200

    Fix export locations update when subnet is added

    Export locations of active share replicas was updated
    but not those of the share itself.

    Closes-Bug: #2017501
    Change-Id: I33204657401f3eadd490fc50fedaef899dcff297
    (cherry picked from commit 07ce64462c63c5253226a733f5686e78eb7223a1)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 19.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/929151
Committed: https://opendev.org/openstack/manila/commit/09ec18ad87b68b205c47fc56002f18a0c4fdd393
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 09ec18ad87b68b205c47fc56002f18a0c4fdd393
Author: Sylvan Le Deunff <email address hidden>
Date: Wed May 3 10:49:12 2023 +0200

    Fix export locations update when subnet is added

    Export locations of active share replicas was updated
    but not those of the share itself.

    Closes-Bug: #2017501
    Change-Id: I33204657401f3eadd490fc50fedaef899dcff297
    (cherry picked from commit 07ce64462c63c5253226a733f5686e78eb7223a1)
    (cherry picked from commit 5b77e4756104554fe024d086241e81e46d71d1ed)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/929152
Committed: https://opendev.org/openstack/manila/commit/2944880f07aa31dea5e812ca832a5bb17851ee38
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 2944880f07aa31dea5e812ca832a5bb17851ee38
Author: Sylvan Le Deunff <email address hidden>
Date: Wed May 3 10:49:12 2023 +0200

    Fix export locations update when subnet is added

    Export locations of active share replicas was updated
    but not those of the share itself.

    Closes-Bug: #2017501
    Change-Id: I33204657401f3eadd490fc50fedaef899dcff297
    (cherry picked from commit 07ce64462c63c5253226a733f5686e78eb7223a1)
    (cherry picked from commit 5b77e4756104554fe024d086241e81e46d71d1ed)
    (cherry picked from commit 09ec18ad87b68b205c47fc56002f18a0c4fdd393)