Netapp Ipspace naming is confusing

[Maurice Escher]

Hi,

It confuses me (and the operators in my team) to see a vserver in an ipspace of a different neutron subnet because it is being reused per VLAN.

Back on https://bugs.launchpad.net/manila/+bug/1774159 I think we wanted to move forward with using neutron_net_id rather than neutron_subnet_id for the ipspace naming.

The discussions at https://review.opendev.org/c/openstack/manila/+/602140/1..4/manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py#b163 (comments from Goutham and Rodrigo) went in that direction.

But the last patchset https://review.opendev.org/c/openstack/manila/+/602140/3..4 removed this change again. Was there any reason for not going with this approach?

Sorry for digging up this old stuff, but it just popped up again as relevant today,
Maurice

[Vida Haririan (vhariria)]

See additional related discussions at https://meetings.opendev.org/meetings/manila/2023/manila.2023-03-02-15.00.log.html

[Helena (helenadantas)]

To reproduce the bug the following steps were done:

- A neutron lattice with two 2 sublattices was created
- A share has been created on each subnet (2 share servers will be created)
- It was verified in ontap which ipspace was used for each sharing server

[Maurice Escher (maurice-escher)]

Review: https://review.opendev.org/c/openstack/manila/+/885978

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/885978
Committed: https://opendev.org/openstack/manila/commit/ce13de0044f44c5bf808d226ec362e8d2f41dde3
Submitter: "Zuul (22348)"
Branch: master

commit ce13de0044f44c5bf808d226ec362e8d2f41dde3
Author: Helena Dantas <email address hidden>
Date: Thu Jun 15 13:33:18 2023 +0000

    [NetApp] Fix ipspace naming is confusing

    This patch resolves the NetApp ipspace naming to use
    neutron_net_id rather than neutron_subnet_id manila driver.

    Closes-Bug: #2007560

    Change-Id: Id5f2d35dac755aa9ae47a4e42af5d6c3fc5e6f2e

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 18.0.0.0rc1 release candidate.