Tempest test fails for max_api_microversion 2.73

[Alexander Deiter]

Description: Tempest test fails for max_api_microversion 2.73

Steps to reproduce
==================

* Install an OpenStack environment using Manila master branch
* Install tempest and manila-tempest-plugin
* Set max_api_microversion=2.73 for the share section of tempest/etc/tempest.conf

[share]
max_api_microversion = 2.73

* Run tempest test suite

Expected results
================

Success

Actual results
==============

======
Totals
======
Ran: 1013 tests in 0.4160 sec.
 - Passed: 845
 - Skipped: 166
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 2
Sum of execute time for each test: 3864.0893 sec.

{3} manila_tempest_tests.tests.api.test_shares_actions.SharesActionsTest.test_get_snapshot_3_2_73 [0.091658s] ... FAILED

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/ddt.py", line 220, in wrapper'
    b' return func(self, *args, **kwargs)'
    b' File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/manila_tempest_tests/tests/api/test_shares_actions.py", line 475, in test_get_snapshot'
    b' self.assertEqual(set(expected_keys), set(actual_keys))'
    b' File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 393, in assertEqual'
    b' self.assertThat(observed, matcher, message)'
    b' File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 480, in assertThat'
    b' raise mismatch_error'
    b'testtools.matchers._impl.MismatchError: !=:'
    b"reference = {'created_at',"
    b" 'description',"
    b" 'id',"
    b" 'links',"
    b" 'name',"
    b" 'project_id',"
    b" 'share_id',"
    b" 'share_proto',"
    b" 'share_size',"
    b" 'size',"
    b" 'status',"
    b" 'user_id'}"
    b"actual = {'created_at',"
    b" 'description',"
    b" 'id',"
    b" 'links',"
    b" 'metadata',"
    b" 'name',"
    b" 'project_id',"
    b" 'share_id',"
    b" 'share_proto',"
    b" 'share_size',"
    b" 'size',"
    b" 'status',"
    b" 'user_id'}"
    b''
    b''

{3} manila_tempest_tests.tests.api.test_shares_actions.SharesActionsTest.test_list_snapshots_with_detail_4_2_73 [0.492753s] ... FAILED

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/ddt.py", line 220, in wrapper'
    b' return func(self, *args, **kwargs)'
    b' File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/manila_tempest_tests/tests/api/test_shares_actions.py", line 552, in test_list_snapshots_with_detail'
    b' [self.assertEqual(set(expected_keys), set(s.keys())) for s in snaps]'
    b' File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/manila_tempest_tests/tests/api/test_shares_actions.py", line 552, in <listcomp>'
    b' [self.assertEqual(set(expected_keys), set(s.keys())) for s in snaps]'
    b' File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 393, in assertEqual'
    b' self.assertThat(observed, matcher, message)'
    b' File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 480, in assertThat'
    b' raise mismatch_error'
    b'testtools.matchers._impl.MismatchError: !=:'
    b"reference = {'created_at',"
    b" 'description',"
    b" 'id',"
    b" 'links',"
    b" 'name',"
    b" 'project_id',"
    b" 'share_id',"
    b" 'share_proto',"
    b" 'share_size',"
    b" 'size',"
    b" 'status',"
    b" 'user_id'}"
    b"actual = {'created_at',"
    b" 'description',"
    b" 'id',"
    b" 'links',"
    b" 'metadata',"
    b" 'name',"
    b" 'project_id',"
    b" 'share_id',"
    b" 'share_proto',"
    b" 'share_size',"
    b" 'size',"
    b" 'status',"
    b" 'user_id'}"
    b''
    b''

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/861335

[Alexander Deiter (adeiter)]

Proposed fix has been successfully tested:

Totals
======
Ran: 1013 tests in 2143.5764 sec.
 - Passed: 847
 - Skipped: 166
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 0
Sum of execute time for each test: 3868.9055 sec.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/861335
Committed: https://opendev.org/openstack/manila-tempest-plugin/commit/75dbca626e46b26dda38e98b3f98e9f5cf7f5b4c
Submitter: "Zuul (22348)"
Branch: master

commit 75dbca626e46b26dda38e98b3f98e9f5cf7f5b4c
Author: Alexander Deiter <email address hidden>
Date: Tue Oct 18 14:07:21 2022 +0300

    Add a metadata field shown on API >= 2.73

    Fixed SharesActionsTest cases for API version >= 2.73
    since a metadata field was added in that version.

    Closes-bug: #1993283
    Signed-off-by: Alexander Deiter <email address hidden>
    Change-Id: Ib285d9c740558d1ff3e24acb1ccc3de7e1ad562f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/861793

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/861793
Committed: https://opendev.org/openstack/manila-tempest-plugin/commit/3d2b7bb036fd8fd3bff51fa14e300d1cb480e56d
Submitter: "Zuul (22348)"
Branch: master

commit 3d2b7bb036fd8fd3bff51fa14e300d1cb480e56d
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Oct 18 13:06:02 2022 -0700

    More Snapshot metadata field verification >= 2.73

    Fix Manage*SnapshotTest cases for API version >= 2.73
    since a metadata field was added in that version.

    Change-Id: I3595b4a5d51a739976243f1484179034993900ed
    Closes-bug: #1993283
    Signed-off-by: Goutham Pacha Ravi <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila-tempest-plugin 1.11.0 release.