Share server migration cancel not displaying the UUID of the share server when migration not found

[Carlos Eduardo]

Description
===========
While trying to cancel a migration of a share server, if the share server is not being migrated, the API should raise a exception, with a message containing the UUID of the share server, warning the administrator that the share server is currently not being migrated.

Steps to reproduce
==================

* Create a share
* Get the ID of a share server
* Attempt to cancel the migration of the share server that is not being migrated

Expected result
===============
The API should respond a message saying what is the ID of the share server that could not have the migration cancelled.

Actual result
=============
The UUID of the share server is not being displayed. [1]

Environment
===========
1. Devstack with manila installed on the master branch

2. A dummy driver backend that supports DHSS=True

[1] https://paste.opendev.org/show/bxEu60wtJXpwwFnJFmQr/

[Vida Haririan (vhariria)]

Additional comments at https://meetings.opendev.org/meetings/manila/2022/manila.2022-09-22-15.00.log.html

[Clifford Emeka (emclidon)]

Hi,

Is the bug still open so I can take it up?

[Vida Haririan (vhariria)]

Hello, Thank you for you interest in this bug.
yes the bug is still open and it was revisited on 2022-09-22 (#1).

[Clifford Emeka (emclidon)]

Thanks Vida,

I need help with the location of the error message where I can fix this. I have been looking inside python-manilaclient within share-servers.

Could you assist with where I can look to make the fix?

Thanks

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/878206
Committed: https://opendev.org/openstack/manila/commit/86e0e3887f466195c073a210b67c2407597c6bec
Submitter: "Zuul (22348)"
Branch: master

commit 86e0e3887f466195c073a210b67c2407597c6bec
Author: Clifford Emeka <email address hidden>
Date: Wed Mar 22 12:18:37 2023 +0100

    adds share server uuid on migration cancel

    Closes-bug: #1989819

    Change-Id: I6064d31d20eb10c5e0d42e9aff18d512c200e378

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/manila/+/879693

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 17.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/879693
Committed: https://opendev.org/openstack/manila/commit/c924c4ce10c167fc8bcb8cb1f4791908d465a5df
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit c924c4ce10c167fc8bcb8cb1f4791908d465a5df
Author: Clifford Emeka <email address hidden>
Date: Wed Mar 22 12:18:37 2023 +0100

    adds share server uuid on migration cancel

    Closes-bug: #1989819

    Change-Id: I6064d31d20eb10c5e0d42e9aff18d512c200e378
    (cherry picked from commit 86e0e3887f466195c073a210b67c2407597c6bec)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/manila/+/897963

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 16.1.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/897963
Committed: https://opendev.org/openstack/manila/commit/bd344c8781dfac12136caeda92bdd19c33665f76
Submitter: "Zuul (22348)"
Branch: stable/zed

commit bd344c8781dfac12136caeda92bdd19c33665f76
Author: Clifford Emeka <email address hidden>
Date: Wed Mar 22 12:18:37 2023 +0100

    adds share server uuid on migration cancel

    Closes-bug: #1989819

    Change-Id: I6064d31d20eb10c5e0d42e9aff18d512c200e378
    (cherry picked from commit 86e0e3887f466195c073a210b67c2407597c6bec)
    (cherry picked from commit c924c4ce10c167fc8bcb8cb1f4791908d465a5df)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila/+/898445

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/manila/+/898446

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 15.3.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/898445
Committed: https://opendev.org/openstack/manila/commit/deee9ae1e40d90c8f951a880a4cf8d844f1db972
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit deee9ae1e40d90c8f951a880a4cf8d844f1db972
Author: Clifford Emeka <email address hidden>
Date: Wed Mar 22 12:18:37 2023 +0100

    adds share server uuid on migration cancel

    Closes-bug: #1989819

    Change-Id: I6064d31d20eb10c5e0d42e9aff18d512c200e378
    (cherry picked from commit 86e0e3887f466195c073a210b67c2407597c6bec)
    (cherry picked from commit c924c4ce10c167fc8bcb8cb1f4791908d465a5df)
    (cherry picked from commit bd344c8781dfac12136caeda92bdd19c33665f76)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/manila/+/905458

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/898446
Committed: https://opendev.org/openstack/manila/commit/5415c64efda29301e74da2f6c75a767191e47b96
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 5415c64efda29301e74da2f6c75a767191e47b96
Author: Clifford Emeka <email address hidden>
Date: Wed Mar 22 12:18:37 2023 +0100

    adds share server uuid on migration cancel

    Closes-bug: #1989819

    Change-Id: I6064d31d20eb10c5e0d42e9aff18d512c200e378
    (cherry picked from commit 86e0e3887f466195c073a210b67c2407597c6bec)
    (cherry picked from commit c924c4ce10c167fc8bcb8cb1f4791908d465a5df)
    (cherry picked from commit bd344c8781dfac12136caeda92bdd19c33665f76)
    (cherry picked from commit deee9ae1e40d90c8f951a880a4cf8d844f1db972)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/905458
Committed: https://opendev.org/openstack/manila/commit/97ae87e9702875fc0bdc38d065865baf4a74b32f
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 97ae87e9702875fc0bdc38d065865baf4a74b32f
Author: Clifford Emeka <email address hidden>
Date: Wed Mar 22 12:18:37 2023 +0100

    adds share server uuid on migration cancel

    Closes-bug: #1989819

    Change-Id: I6064d31d20eb10c5e0d42e9aff18d512c200e378
    (cherry picked from commit 86e0e3887f466195c073a210b67c2407597c6bec)
    (cherry picked from commit c924c4ce10c167fc8bcb8cb1f4791908d465a5df)
    (cherry picked from commit bd344c8781dfac12136caeda92bdd19c33665f76)
    (cherry picked from commit deee9ae1e40d90c8f951a880a4cf8d844f1db972)
    (cherry picked from commit 5415c64efda29301e74da2f6c75a767191e47b96)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 14.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila xena-eom release.