Get replica state from backend before promotion

[kiran pawar]

Description
===========
The promote share replica s using the NetApp driver.

Steps to reproduce
==================

* Create a share replica of the created share
* Wait for the replica to achieve 'in_sync' state
* Promote the share replica
* Wait for error
* sometime replica gets promoted, but sometime it fails.
filed bug to address failure scenario.

Possible description
====================
when replica state is retrieved from DB, it might be in IN_SYNC state. However this state is updated every 5 minute, it is possible that replica becomes OUT_SYNC after its state is read from backend. Then user tries to promote replica assuming its in IN_SYNC state. Also when retrieve from DB, state is IN_SYNC, but thereafter promotion fails since replica is actually OUT_SYNC. So retrieve current state from backend, then update in db and then try to promote only if its in IN_SYNC.

[Vida Haririan (vhariria)]

Link to the proposed fix https://review.opendev.org/c/openstack/manila/+/856539

[Vida Haririan (vhariria)]

Additional comments at https://meetings.opendev.org/meetings/manila/2022/manila.2022-11-03-15.00.log.html

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Carlos Eduardo <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/manila/+/856539
Reason: Abandoning this change as suggested by Chuan, as this issue is being solved elsewhere.

[Vida Haririan (vhariria)]

See additional related discussions at https://meetings.opendev.org/meetings/manila/2023/manila.2023-10-19-15.00.log.html