scheduler's capacity filter fails to pass when extending share

[chuan137]

Extend share fails because of no host is found by the scheduler's capacity filer. In the following example, the requested share size is smaller than the available capacity, and the maximum over subscription ration is 1.0001. However, the would-be provision ratio, 1.61, is calculated incorrectly.

> Space information for share creation on host manila-share-netapp-ma01-st057@ma01-st057#aggr_ssd_stnpa1_02_st057_1 (requested / avail): 44032/45747
> Insufficient free space for thin provisioning. The ratio of provisioned capacity over total capacity 1.61 would exceed the maximum over subscription ratio 1.00

It seems to happen because the ratio calculation algorithm takes the share size rather than the share size increase into account.

> provisioned_ratio = ((host_state.provisioned_capacity_gb +
> share_size) / total)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/838273

[haixin (haixin77)]

patch link:
https://review.opendev.org/c/openstack/manila/+/838273

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/838273
Committed: https://opendev.org/openstack/manila/commit/e5d644fec32823a24ef17de6f08c45d273dfd23b
Submitter: "Zuul (22348)"
Branch: master

commit e5d644fec32823a24ef17de6f08c45d273dfd23b
Author: haixin <email address hidden>
Date: Mon Apr 18 12:42:18 2022 +0800

    update capacity filter during extend share

    use size increase to calculate provisioned_ratio during
    extend share.

    Closes-Bug: #1968891

    Change-Id: I2d4903d6a2fda588b126a062c755db2fa2b09cdb

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 16.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/manila/+/876227

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila/+/876228

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/manila/+/876229

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/876227
Committed: https://opendev.org/openstack/manila/commit/19be7bb13ab988712b4aa57f0d9e73eecb2fb0af
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 19be7bb13ab988712b4aa57f0d9e73eecb2fb0af
Author: haixin <email address hidden>
Date: Mon Apr 18 12:42:18 2022 +0800

    update capacity filter during extend share

    use size increase to calculate provisioned_ratio during
    extend share.

    Closes-Bug: #1968891

    Change-Id: I2d4903d6a2fda588b126a062c755db2fa2b09cdb
    (cherry picked from commit e5d644fec32823a24ef17de6f08c45d273dfd23b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/876228
Committed: https://opendev.org/openstack/manila/commit/9e05299994936afce80229cf8fa522f1d18a326b
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 9e05299994936afce80229cf8fa522f1d18a326b
Author: haixin <email address hidden>
Date: Mon Apr 18 12:42:18 2022 +0800

    update capacity filter during extend share

    use size increase to calculate provisioned_ratio during
    extend share.

    Closes-Bug: #1968891

    Change-Id: I2d4903d6a2fda588b126a062c755db2fa2b09cdb
    (cherry picked from commit e5d644fec32823a24ef17de6f08c45d273dfd23b)
    (cherry picked from commit 19be7bb13ab988712b4aa57f0d9e73eecb2fb0af)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/876229
Committed: https://opendev.org/openstack/manila/commit/24a1b097ec916d00a0b312ce3f7f9491b55e0ee4
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 24a1b097ec916d00a0b312ce3f7f9491b55e0ee4
Author: haixin <email address hidden>
Date: Mon Apr 18 12:42:18 2022 +0800

    update capacity filter during extend share

    use size increase to calculate provisioned_ratio during
    extend share.

    Closes-Bug: #1968891

    Change-Id: I2d4903d6a2fda588b126a062c755db2fa2b09cdb
    (cherry picked from commit e5d644fec32823a24ef17de6f08c45d273dfd23b)
    (cherry picked from commit 19be7bb13ab988712b4aa57f0d9e73eecb2fb0af)
    (cherry picked from commit 9e05299994936afce80229cf8fa522f1d18a326b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 15.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 13.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 14.1.0 release.