Manila unit tests KeyError: 'service' and 'reason'
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Shared File Systems Service (Manila) |
Fix Released
|
Undecided
|
Alex Deiter |
Bug Description
Description: Manila unit tests raise a lot of KeyError exceptions
Steps to reproduce:
- Deploy a DevStack environment with Manila service enabled (master branch)
- Run Manila unit tests (tox -e py3)
Expected results:
- Success
- No exception messages
Actual result:
Manila unit tests raise a lot of KeyError exceptions, for example:
$ tox -e py3
py3 run-test: commands[0] | stestr run
Exception in string format operation.
Traceback (most recent call last):
File "/opt/stack/
message = self.message % kwargs
KeyError: 'service'
code: 400
Exception in string format operation.
Traceback (most recent call last):
File "/opt/stack/
message = self.message % kwargs
KeyError: 'reason'
code: 400
...
Total errors:
$ tox -e py3 -- 2>&1 | grep KeyError | sort | uniq -c
2 KeyError: 'err'
2 KeyError: 'msg'
8 KeyError: 'reason'
1 KeyError: 'result'
2 KeyError: 'service'
2 KeyError: 'share_server_id'
1 KeyError: 'snapshot_name'
Root cause: missed keyword arguments for Manila exceptions in some unit tests.
Changed in manila: | |
assignee: | nobody → Alex Deiter (deiter) |
Fix proposed to branch: master /review. opendev. org/c/openstack /manila/ +/835239
Review: https:/