Manila unit tests KeyError: 'service' and 'reason'

[Alex Deiter]

Description: Manila unit tests raise a lot of KeyError exceptions

Steps to reproduce:
- Deploy a DevStack environment with Manila service enabled (master branch)
- Run Manila unit tests (tox -e py3)

Expected results:
- Success
- No exception messages

Actual result:
Manila unit tests raise a lot of KeyError exceptions, for example:
$ tox -e py3
py3 run-test: commands[0] | stestr run
Exception in string format operation.
Traceback (most recent call last):
  File "/opt/stack/manila/manila/exception.py", line 88, in __init__
    message = self.message % kwargs
KeyError: 'service'
code: 400
Exception in string format operation.
Traceback (most recent call last):
  File "/opt/stack/manila/manila/exception.py", line 88, in __init__
    message = self.message % kwargs
KeyError: 'reason'
code: 400
...

Total errors:
$ tox -e py3 -- 2>&1 | grep KeyError | sort | uniq -c
      2 KeyError: 'err'
      2 KeyError: 'msg'
      8 KeyError: 'reason'
      1 KeyError: 'result'
      2 KeyError: 'service'
      2 KeyError: 'share_server_id'
      1 KeyError: 'snapshot_name'

Root cause: missed keyword arguments for Manila exceptions in some unit tests.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/835239

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/835239
Committed: https://opendev.org/openstack/manila/commit/6669330d926d01691ea0788e72a361b6e75ddefb
Submitter: "Zuul (22348)"
Branch: master

commit 6669330d926d01691ea0788e72a361b6e75ddefb
Author: Alex Deiter <email address hidden>
Date: Fri Mar 25 12:01:55 2022 +0000

    Fix KeyError exceptions in Manila unit tests

    Added missed 'service' and 'reason' keywords for Manila exceptions unit tests.

    Closes-bug: #1966473
    Change-Id: I70533951f46cddd171b1979ed57a59a5448a4557

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 15.0.0.0rc1 release candidate.