manila error TypeError: update_access() missing 1 required positional argument: 'delete_rules'

[Satish Patel]

Reference: https://bugs.launchpad.net/manila/+bug/1964696

After applying patch https://review.opendev.org/c/openstack/manila/+/833689/1/manila/share/drivers/glusterfs/__init__.py

I got encounter following errors when i create share and apply access rules

2022-03-14 23:52:52.985 17 INFO manila.message.api [req-ce38372d-a51b-433c-8f2e-203cca0a1344 8863bb3eb7c746db8c9e3eccc4346fb7 3a864fd72b92403cb352ec9236709435 - - -] Creating message record for request_id = req-ce38372d-a51b-433c-8f2e-203cca0a1344
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server [req-ce38372d-a51b-433c-8f2e-203cca0a1344 8863bb3eb7c746db8c9e3eccc4346fb7 3a864fd72b92403cb352ec9236709435 - - -] Exception during message handling: TypeError: update_access() missing 1 required positional argument: 'delete_rules'
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server Traceback (most recent call last):
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/oslo_messaging/rpc/server.py", line 165, in _process_incoming
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/oslo_messaging/rpc/dispatcher.py", line 309, in dispatch
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/oslo_messaging/rpc/dispatcher.py", line 229, in _do_dispatch
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/manila/share/manager.py", line 219, in wrapped
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server return f(self, *args, **kwargs)
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/manila/utils.py", line 578, in wrapper
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server return func(self, *args, **kwargs)
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/manila/share/manager.py", line 3364, in delete_share_instance
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server self.message_api.create(
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/oslo_utils/excutils.py", line 227, in __exit__
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server self.force_reraise()
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/oslo_utils/excutils.py", line 200, in force_reraise
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server raise self.value
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/manila/share/manager.py", line 3342, in delete_share_instance
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server self.access_helper.update_access_rules(
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/manila/share/access.py", line 301, in update_access_rules
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server self._update_access_rules(context, share_instance_id,
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/manila/share/access.py", line 338, in _update_access_rules
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server driver_rule_updates = self._update_rules_through_share_driver(
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/manila/share/access.py", line 403, in _update_rules_through_share_driver
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server driver_rule_updates = self.driver.update_access(
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/manila/share/drivers/glusterfs/layout.py", line 147, in update_access
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server self._update_access_via_manager(gluster_mgr, context, share,
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/manila/share/drivers/glusterfs/__init__.py", line 154, in _update_access_via_manager
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server self._get_helper(gluster_mgr).update_access(
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server File "/var/lib/kolla/venv/lib/python3.8/site-packages/manila/share/drivers/glusterfs/__init__.py", line 314, in update_access
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server super(GaneshaNFSHelper, self).update_access(
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server TypeError: update_access() missing 1 required positional argument: 'delete_rules'
2022-03-14 23:52:53.012 17 ERROR oslo_messaging.rpc.server

[Goutham Pacha Ravi (gouthamr)]

This bug doesn't exist in the code, it was reported while testing a patch in progress: https://review.opendev.org/c/openstack/manila/+/833689

https://meetings.opendev.org/irclogs/%23openstack-manila/%23openstack-manila.2022-03-14.log.html
https://meetings.opendev.org/irclogs/%23openstack-manila/%23openstack-manila.2022-03-15.log.html