test_service_enabled_on_create_based_on_flag fails intermittently

[Goutham Pacha Ravi]

A unit test "manila.tests.test_service.ServiceFlagsTestCase.test_service_enabled_on_create_based_on_flag" fails intermittently in the gate with the following traceback:

 manila.tests.test_service.ServiceFlagsTestCase.test_service_enabled_on_create_based_on_flag
 -------------------------------------------------------------------------------------------

 Captured traceback:
 ~~~~~~~~~~~~~~~~~~~
     Traceback (most recent call last):

       File "/home/zuul/src/opendev.org/openstack/manila/manila/tests/test_service.py", line 92, in test_service_enabled_on_create_based_on_flag
     app.wait()

       File "/home/zuul/src/opendev.org/openstack/manila/manila/service.py", line 256, in wait
     self.rpcserver.wait()

     AttributeError: 'FakeRpcServer' object has no attribute 'wait'

Line 92's "app.wait()" logic was introduced in the yoga release as part of: https://review.opendev.org/c/openstack/manila/+/825110/31/manila/tests/test_service.py#92

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/833176

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/833176
Committed: https://opendev.org/openstack/manila/commit/3d04487fa89ee01433c08b41ea367d0d5090cf8a
Submitter: "Zuul (22348)"
Branch: master

commit 3d04487fa89ee01433c08b41ea367d0d5090cf8a
Author: silvacarloss <email address hidden>
Date: Thu Mar 10 17:52:24 2022 -0300

    Fix sporadic test failure in manila

    Fixes a sporadic unit test failure that was introduced during
    Yoga by removing an unecessary waiter.

    Closes-bug: #1964521
    Change-Id: If26a54c1a43cbf82b38ab9fa034e5e1c0ff88fe4

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 14.0.0.0rc1 release candidate.