NetApp delete volume with ongoing clone split

[Maurice Escher]

Hi,

shares that were created from snapshot and are deleted after a short lifetime end up in error_deleting. Now I have to come back later, reset state and try to delete again.
In the logs I see "Failed to unmount volume [...] after waiting for 30 seconds."

My expectation would be: deleting a share from snapshot works without waiting + retry.

I have Manila Xena with ONTAP 9.8 back end and set netapp:split_clone_on_create to "True".

Previously there may have been no way in figuring out that a clone split operation was ongoing (see https://opendev.org/openstack/manila/src/branch/stable/xena/manila/share/drivers/netapp/dataontap/client/client_cmode.py#L3087-L3096) but now in more recent ONTAP versions there is a 'volume-clone-split-status' command.

I suggest to improve the user experience: instead of waiting a few seconds for the job to finish (which may not be enough), stop the clone split in case of a unmount with force flag.

What do you think?

BR,
Maurice

[Maurice Escher (maurice-escher)]

Another idea would be to re-use the concept of soft-deleting from 'soft_delete_snapshot':
in case of an error on share delete, rename the share and try to delete later.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/846973

[Maurice Escher (maurice-escher)]

Please see https://bugs.launchpad.net/manila/+bug/2025641, deferred deletion may not be so easy to implement, since even rename could not be possible on a busy volume (just an assumption from a similar behaviour on snapshots)

[kiran pawar (kpdev)]

proposed - https://review.opendev.org/c/openstack/manila/+/888927

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/888927
Committed: https://opendev.org/openstack/manila/commit/54c4f91aa11b05f815690d9438c5fc9bd4e5386c
Submitter: "Zuul (22348)"
Branch: master

commit 54c4f91aa11b05f815690d9438c5fc9bd4e5386c
Author: Kiran Pawar <email address hidden>
Date: Wed Jul 19 14:05:59 2023 +0000

    NetApp: Stop clone split while deleting child share.

    If share created from snapshot is deleted immediately after creation
    and if clone split operation is in progress, then delete call fails.
    Fix this issue by first stopping the clone split job and then continue
    with deletion.

    Closes-bug: #1960239
    Change-Id: If9844b3da70cec427c6260ee239c8c6131ed77ed

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 18.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Goutham Pacha Ravi <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/manila/+/846973
Reason: A different approach was taken here: https://review.opendev.org/c/openstack/manila/+/888927

It is up to NetApp maintainers to pursue a backport to older/stable releases if it helps consumers.