NetApp driver fails to create a CIFS share when associating only active_directory as security service

[Nahim Alves de Souza]

Description
===========

When a user tries to create a CIFS share, the NetApp driver is requiring to associate a mandatory network security service even if Active Directory is already configured.

Steps to reproduce
==================

1. Configure a share network and a security service on manila client [1]
2. Try to create a CIFS share

Expected result
===============
Create a CIFS share successfully, since Active Directory should be the only network security service required to create a CIFS share.

Actual result
=============
Creation process returned an error with the message "Share network security service association is mandatory for protocol CIFS." [2]

Environment
===========
1. OpenStack Manila
   > manila --version: 2.7.1
   > manila-share --version: 12.1.0

2. Backend
   > NetApp ONTAP 9.8

Logs & Configs
==============

[1] https://netapp-openstack-dev.github.io/openstack-docs/draft/manila/examples/openstack_command_line/section_manila-cli.html#creating-a-manila-cifs-share-with-security-service

[2] https://paste.opendev.org/show/808411/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/806764

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/806764
Committed: https://opendev.org/openstack/manila/commit/58031e369305337475aa20efb060b3061a5681cb
Submitter: "Zuul (22348)"
Branch: master

commit 58031e369305337475aa20efb060b3061a5681cb
Author: Nahim Alves de Souza <email address hidden>
Date: Tue Aug 31 14:52:11 2021 +0000

    [NetApp] Fix list of mandatory services for CIFS share creation

    To create a CIFS share, it is mandatory to configure an active
    directory service, but the code was requiring to configure also
    the `ldap` and `kerberos` services to be configured during the
    creation of a CIFS share.

    This patch fixes this, removing `ldap` and `kerberos` from the
    list of mandatory security services.

    Change-Id: I34020da6a929f5c7ae1c63bc0f2ef338c49dbe10
    Closes-bug: #1942124

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 13.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/820955

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/820955
Committed: https://opendev.org/openstack/manila/commit/578e3c78c2aa90555e65924657e630bdc843be28
Submitter: "Zuul (22348)"
Branch: master

commit 578e3c78c2aa90555e65924657e630bdc843be28
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Dec 7 14:21:27 2021 -0800

    Move release notes to correct folders

    Idb4b6de5108dd1862df7de97d0ffdc15282b1d74 recently merged and
    is backport worthy to all maintained older stable releases.

    I34020da6a929f5c7ae1c63bc0f2ef338c49dbe10 was committed
    to stable/xena when it was still under development; the bug-fix
    in question is not back portable to other stable branches, so
    backporting this release note fix to stable/xena should suffice.

    Change-Id: I751b6e4a3288cde7a98c0ddc55deac7a0682010d
    Related-bug: #1942124
    Related-Bug: #1475351
    Signed-off-by: Goutham Pacha Ravi <email address hidden>