NetApp driver DHSS mode fails to create share on a new added pool

[Felipe Rodrigues]

Description
===========
The DHSS true mode driver reuses the share server for placing new shares. The NetApp driver creates the share server accessing the current available pools for the backend. For example, if the backend has the pool aggr1 and aggr2, the share server would have the aggr1 and aggr2. So, all shares places in that share server must be on pools aggr1 and aggr2.

The problem is that the reuse share server for a share is not checking if the share's pool is part of share server aggregates. So, new added pools cannot have shares create whether any share server exists.

Steps to reproduce
==================

A ONTAP cluster with aggregates aggr1 and aggr2.

1) Setup the backend using only one of the aggregates in the DHSS mode, netapp_aggregate_name_search_pattern=aggr1

2) Create a share (which ends up creating a share server)

3) Change the backend setup by adding the other aggregate:
netapp_aggregate_name_search_pattern=aggr[1-2]

4) Restart the service

5) Create a new share on the pool aggr2

Expected result
===============

It should create the share inside a new share server that controls the new added pool.

Actual result
=============

It reuses the share server that has not the share pool.

Environment
===========
1. Manila version: Latest 12.1.0

2. NetApp ONTAP 9.8

3. DHSS True mode

Logs & Configs
==============

Error reported by shr:
http://paste.openstack.org/show/805286/

[Goutham Pacha Ravi (gouthamr)]

Felipe, we're closing on xena-RC1 soon.

i'm moving this bug to Yoga-1; please let me know if that timeline is inaccurate.

[Vida Haririan (vhariria)]

Notes from Yoga M-1 Bug Squash - 'Moved from Yoga-1 to Yoga-2 - low, no customers hitting this

[Maurice Escher (maurice-escher)]

Hi, there is also another possible expected result:

When changing the netapp_aggregate_name_search_pattern all existing share servers are adapted to serve all pools/aggregates that match.
And then the new share reuses the existing share server, which now can also use the newly added pool.

The beauty with that is: all share servers are the same (at least regarding the aggr-list) instead of having two different kinds (pre and post search pattern modification)

BR,
Maurice

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/834503

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/834503
Committed: https://opendev.org/openstack/manila/commit/7e08ed4ce5c7e578148e71f709c15eeeb50be92c
Submitter: "Zuul (22348)"
Branch: master

commit 7e08ed4ce5c7e578148e71f709c15eeeb50be92c
Author: andrebeltrami <email address hidden>
Date: Mon Mar 21 08:43:09 2022 -0300

    [NetApp] Fix DHSS mode fails to create share on a new pool

    This patch fixes #1928241 checking if the share pool name
    is in vserver aggregates list, if it is not, the share server
    cannot be reused and a new one is created. This fix also
    includes NetApp Flexgroup and Flexvol.

    Closes-Bug: #1928241
    Change-Id: I24bf98f6d7c962ff9430748ff0bc88c647b9946c

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 16.0.0.0rc1 release candidate.