incorrect error message creating snapshot from share that does not support it
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Shared File Systems Service (Manila) |
Fix Released
|
Medium
|
Tom Barron |
Bug Description
Description
===========
When attempting to create a snapshot from a share that does not support snapshot creation, the user gets a message like the following:
ERROR: Snapshot cannot be created from share 'f95eb067-
The message is incorrect in that the actual share back end may well support snapshot creation but the share was created using a share-type without the 'snapshot_support' extra spec set to True. Without this, the share created will have its snapshot_support property set to False and snapshots cannot be created from it irrespective of the back end capabilities.
This message also violates the principle that back end information is not for regular manila users rather than cloud administrators.
Steps to reproduce:
==================
Deploy manila with a single backend that supports snapshot creation (or multiple backends, all of which have such support). Turn on debug so backend capabilities are shown in the periodic reports to the scheduler log.
Check the scheduler log and observe that the backend(s) report snapshot_support = True.
Create a share type without snapshot_support set at all.
Create a share from the share type.
Show the share and observe that it has snapshot_
Attempt to create a snapshot from the share and see that it errors with a message claiming that the share back end does not support snapshots.
Expected result:
===============
Error message should say that the source share does not support snapshot creation rather than that the back end doesn't.
Changed in manila: | |
importance: | Undecided → Medium |
assignee: | nobody → Tom Barron (tpb) |
milestone: | none → xena-1 |
status: | New → Triaged |
tags: | added: snapshots |
Fix proposed to branch: master /review. opendev. org/c/openstack /manila/ +/787371
Review: https:/