| 2021-04-15 06:46:59 |
Maurice Escher |
bug |
|
|
added bug |
| 2021-04-15 06:49:19 |
Maurice Escher |
description |
Hi,
I believe the intend of share manager's periodic_share_replica_update() is to check on the health of secondary replicas.
https://opendev.org/openstack/manila/src/commit/ad4315eb360ccc9afbd78d4bc5b5e5e0716df87b/manila/share/manager.py#L2566-L2569
Same like periodic_share_replica_snapshot_update() it should not touch the active replica
https://opendev.org/openstack/manila/src/commit/ad4315eb360ccc9afbd78d4bc5b5e5e0716df87b/manila/share/manager.py#L3776-L3779
Or at least the comment for qualified_replica() is wrong ;)
BR,
Maurice |
Hi,
I believe the intend of share manager's periodic_share_replica_update() is to check on the health of secondary replicas.
https://opendev.org/openstack/manila/src/commit/ad4315eb360ccc9afbd78d4bc5b5e5e0716df87b/manila/share/manager.py#L2566-L2569
Same like periodic_share_replica_snapshot_update() it should not touch the active replica
https://opendev.org/openstack/manila/src/commit/ad4315eb360ccc9afbd78d4bc5b5e5e0716df87b/manila/share/manager.py#L3776-L3779
Or at least the comment for qualified_replica() is wrong ;)
I noticed because _share_replica_update() may fail on getting _active_replica later if there is no active replica, e.g. if the share is in error state.
BR,
Maurice |
|
| 2021-04-15 08:10:06 |
OpenStack Infra |
manila: status |
New |
In Progress |
|
| 2021-04-16 08:46:24 |
Maurice Escher |
manila: assignee |
|
Maurice Escher (maurice-escher) |
|
| 2021-07-29 15:42:51 |
Vida Haririan |
manila: importance |
Undecided |
Low |
|
| 2021-09-16 19:47:22 |
Goutham Pacha Ravi |
manila: milestone |
|
xena-rc1 |
|
| 2021-09-20 19:03:07 |
Carlos Eduardo |
manila: milestone |
xena-rc1 |
yoga-1 |
|
| 2021-09-20 19:03:19 |
Carlos Eduardo |
manila: milestone |
yoga-1 |
xena-rc1 |
|
| 2021-09-20 19:07:00 |
Carlos Eduardo |
manila: milestone |
xena-rc1 |
yoga-1 |
|
| 2021-11-29 18:14:59 |
Goutham Pacha Ravi |
manila: milestone |
yoga-1 |
yoga-2 |
|
| 2022-01-13 15:53:40 |
Vida Haririan |
manila: status |
In Progress |
Fix Released |
|
| 2022-01-13 19:01:15 |
OpenStack Infra |
tags |
|
in-stable-wallaby |
|
| 2022-01-13 19:27:28 |
OpenStack Infra |
tags |
in-stable-wallaby |
in-stable-wallaby in-stable-xena |
|
| 2022-01-17 14:48:25 |
OpenStack Infra |
tags |
in-stable-wallaby in-stable-xena |
in-stable-victoria in-stable-wallaby in-stable-xena |
|
| 2022-01-25 19:25:39 |
OpenStack Infra |
tags |
in-stable-victoria in-stable-wallaby in-stable-xena |
in-stable-ussuri in-stable-victoria in-stable-wallaby in-stable-xena |
|
| 2022-03-22 07:40:35 |
OpenStack Infra |
tags |
in-stable-ussuri in-stable-victoria in-stable-wallaby in-stable-xena |
in-stable-train in-stable-ussuri in-stable-victoria in-stable-wallaby in-stable-xena |
|
